mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: joeyli <jlee@suse.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Takashi Iwai <tiwai@suse.de>,
	"Lee, Chun-Yi" <joeyli.kernel@gmail.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Len Brown <len.brown@intel.com>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Hibernate: check unsafe page should not in e820 reserved region
Date: Mon, 4 Aug 2014 22:56:40 +0800	[thread overview]
Message-ID: <20140804145640.GE16024@linux-rxt1.site> (raw)
In-Reply-To: <20140804130810.GA23098@amd.pavel.ucw.cz>

Hi Pavel, 

Thanks for your review!

On Mon, Aug 04, 2014 at 03:08:11PM +0200, Pavel Machek wrote:
> > > +
> > > +	list_for_each_entry(region, &nosave_regions, list) {
> > > +		if (pfn >= region->start_pfn && pfn < region->end_pfn) {
> > > +			pr_err("PM: %#010llx in e820 nosave regsion: "
> 
> And while looking at it, this should probably be spelled "region".
>  
> ...plus maybe past part of changelog here into the comment?
> 

Oh, sorry for my typo! I will correct it and comment in next version. 

> Otherwise looks good to me, 
> 
> Acked-by: Pavel Machek <pavel@ucw.cz>
> 									Pavel

Regards
Joey Lee

  reply	other threads:[~2014-08-04 14:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-04 10:33 Lee, Chun-Yi
2014-08-04 12:42 ` Takashi Iwai
2014-08-04 13:08   ` Pavel Machek
2014-08-04 14:56     ` joeyli [this message]
2014-08-04 14:52   ` joeyli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140804145640.GE16024@linux-rxt1.site \
    --to=jlee@suse.com \
    --cc=joeyli.kernel@gmail.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rjw@rjwysocki.net \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®