From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.cz>, Alan Cox <alan@linux.intel.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Murali Karicheri <m-karicheri2@ti.com>,
Jingoo Han <jg1.han@samsung.com>,
Michael Welling <mwelling@ieee.org>,
Peter Hurley <peter@hurleysoftware.com>,
Joe Schultz <jschultz@xes-inc.com>, Ingo Molnar <mingo@elte.hu>,
Doug Anderson <dianders@chromium.org>,
linux-serial@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2 v2] serial: Add support for Fintek F81216A LPC to 4 UART
Date: Tue, 5 Aug 2014 10:34:09 +0100 [thread overview]
Message-ID: <20140805103409.33afef2a@alan.etchedpixels.co.uk> (raw)
In-Reply-To: <CAPybu_2U2jjyY_9gji41mUc5F4N+idDVNO=LAr3F5PpJ0JzYSg@mail.gmail.com>
On Fri, 1 Aug 2014 14:28:11 +0200
Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> wrote:
> Hello
>
> >> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> >
> > This half of things looks good to me.
>
>
> Thanks!, What about the other half? Would you accept a two step approach?
>
> 1st: add support for 8250_core
> 2nd: handle rs485 ioctl on serial_core and modify all the other
> drivers to use that? (to avoid code duplication)
We really want to handle it at the tty layer I think not at serial_core.
I have a patch for that and I'm playing with it but it's taking longer
than I hoped.
In the mean time I think your patch #1 is ok except for the trivial
item that I'd prefer the struct serial_rs485 was further down the struct
uart_8250_port. It's packed so that the bits you need most are in the
first cache line or two.
Alan
next prev parent reply other threads:[~2014-08-05 9:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 16:27 [PATCH 1/2] serial/8250: Add support for RS485 IOCTLs Ricardo Ribalda Delgado
2014-07-29 16:27 ` [PATCH 2/2] serial: Add support for Fintek F81216A LPC to 4 UART Ricardo Ribalda Delgado
2014-07-31 14:19 ` One Thousand Gnomes
2014-07-31 16:07 ` Ricardo Ribalda Delgado
2014-07-31 19:22 ` [PATCH 2/2 v2] " Ricardo Ribalda Delgado
2014-08-01 12:23 ` One Thousand Gnomes
2014-08-01 12:28 ` Ricardo Ribalda Delgado
2014-08-05 9:34 ` One Thousand Gnomes [this message]
2014-08-05 9:47 ` Ricardo Ribalda Delgado
2014-07-31 14:07 ` [PATCH 1/2] serial/8250: Add support for RS485 IOCTLs One Thousand Gnomes
2014-07-31 16:13 ` Ricardo Ribalda Delgado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140805103409.33afef2a@alan.etchedpixels.co.uk \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=alan@linux.intel.com \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jg1.han@samsung.com \
--cc=jschultz@xes-inc.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=mingo@elte.hu \
--cc=mwelling@ieee.org \
--cc=peter@hurleysoftware.com \
--cc=ricardo.ribalda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®