From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: linux-kernel@vger.kernel.org, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
rdunlap@infradead.org, gregkh@linuxfoundation.org,
jslaby@suse.cz, grant.likely@linaro.org,
heikki.krogerus@linux.intel.com, alan@linux.intel.com,
paul.gortmaker@windriver.com, asierra@xes-inc.com,
mwelling@ieee.org, dianders@chromium.org, m-karicheri2@ti.com,
jschultz@xes-inc.com, mingo@elte.hu, balbi@ti.com,
heiko@sntech.de, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org, linux-serial@vger.kernel.org,
linux-api@vger.kernel.org
Subject: Re: [PATCH 1/3] tty: serial: 8250: Add new capability for highspeed register
Date: Tue, 5 Aug 2014 12:43:43 +0100 [thread overview]
Message-ID: <20140805124343.27ff9b32@alan.etchedpixels.co.uk> (raw)
In-Reply-To: <1407236054-30994-2-git-send-email-matthias.bgg@gmail.com>
>
> /*
> + * Mediatek UARTs use an extra highspeed register (UART_MTK_HIGHS)
> + *
> + * We need to recalcualte the quot register, as the claculation depends
> + * on the vaule in the highspeed register.
> + *
> + * Some baudrates are not supported by the chip, so we use the next
> + * lower rate supported.
> + *
> + * If highspeed register is set to 3, we need to specify sample count
> + * and sample point to increase accuracy. If not, we reset the
> + * registers to their default values.
> + */
Don't put stuff in the core driver core for your chip specific weirdness,
wrap the termios method with your own in your driver code as a fair
number of other 8250ish drivers do.
If you do that then you don't need to waste a UART CAPS flag and you
don't need to put anything in the core driver code.
Alan
next prev parent reply other threads:[~2014-08-05 11:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-05 10:54 [PATCH 0/3] tty: serial: Add mediatek UART driver Matthias Brugger
2014-08-05 10:54 ` [PATCH 1/3] tty: serial: 8250: Add new capability for highspeed register Matthias Brugger
2014-08-05 11:43 ` One Thousand Gnomes [this message]
2014-08-05 10:54 ` [PATCH 2/3] tty: serial: 8250: Add Mediatek UART driver Matthias Brugger
2014-08-05 11:55 ` Varka Bhadram
2014-08-05 12:02 ` Alan Cox
2014-08-05 12:04 ` Varka Bhadram
2014-08-05 13:38 ` Alan Cox
2014-08-05 10:54 ` [PATCH 3/3] DTS: serial: Add bindings documention for the Mediatek UARTs Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140805124343.27ff9b32@alan.etchedpixels.co.uk \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=alan@linux.intel.com \
--cc=asierra@xes-inc.com \
--cc=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jschultz@xes-inc.com \
--cc=jslaby@suse.cz \
--cc=linux-api@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mingo@elte.hu \
--cc=mwelling@ieee.org \
--cc=paul.gortmaker@windriver.com \
--cc=pawel.moll@arm.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®