From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753831AbaHEWXM (ORCPT ); Tue, 5 Aug 2014 18:23:12 -0400 Received: from imap.thunk.org ([74.207.234.97]:46161 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752020AbaHEWXL (ORCPT ); Tue, 5 Aug 2014 18:23:11 -0400 Date: Tue, 5 Aug 2014 18:23:03 -0400 From: "Theodore Ts'o" To: Torsten Duwe Cc: Stephen Boyd , linux-kernel@vger.kernel.org, Matt Mackall , Herbert Xu , "H . Peter Anvin" Subject: Re: [PATCH] hwrng: Pass entropy to add_hwgenerator_randomness() in bits, not bytes Message-ID: <20140805222303.GB26399@thunk.org> Mail-Followup-To: Theodore Ts'o , Torsten Duwe , Stephen Boyd , linux-kernel@vger.kernel.org, Matt Mackall , Herbert Xu , "H . Peter Anvin" References: <1406326758-4516-1-git-send-email-sboyd@codeaurora.org> <20140728094929.GJ972@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140728094929.GJ972@lst.de> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 28, 2014 at 11:49:29AM +0200, Torsten Duwe wrote: > On Fri, Jul 25, 2014 at 03:19:18PM -0700, Stephen Boyd wrote: > > rng_get_data() returns the number of bytes read from the hardware. > > The entropy argument to add_hwgenerator_randomness() is passed > > directly to credit_entropy_bits() so we should be passing the > > number of bits, not bytes here. > > Absolutely correct. > > Acked-by: Torsten Duwe Applied, thanks. - Ted