From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754853AbaHFVIO (ORCPT ); Wed, 6 Aug 2014 17:08:14 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:43766 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754089AbaHFVIM (ORCPT ); Wed, 6 Aug 2014 17:08:12 -0400 Date: Wed, 06 Aug 2014 14:08:11 -0700 (PDT) Message-Id: <20140806.140811.1012784433206389073.davem@davemloft.net> To: zoltan.kiss@citrix.com Cc: wei.liu2@citrix.com, Ian.Campbell@citrix.com, david.vrabel@citrix.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH net-next] xen-netback: Fix vif->disable handling From: David Miller In-Reply-To: <1407353598-14185-1-git-send-email-zoltan.kiss@citrix.com> References: <1407353598-14185-1-git-send-email-zoltan.kiss@citrix.com> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Wed, 06 Aug 2014 14:08:12 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zoltan Kiss Date: Wed, 6 Aug 2014 20:33:18 +0100 > In the patch called "xen-netback: Turn off the carrier if the guest is not able > to receive" new branches were introduced to this if statement, risking that a > queue with non-zero id can reenable the disabled interface. > > Signed-off-by: Zoltan Kiss > Signed-off-by: David Vrabel Can you please resubmit this with curly braces added to the first if()'s basic block? Thanks.