From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754524AbaHFXA7 (ORCPT ); Wed, 6 Aug 2014 19:00:59 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:44529 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754283AbaHFXA5 (ORCPT ); Wed, 6 Aug 2014 19:00:57 -0400 Date: Wed, 06 Aug 2014 16:00:56 -0700 (PDT) Message-Id: <20140806.160056.2041553888385106816.davem@davemloft.net> To: ixaphire@qrator.net Cc: yoshfuji@linux-ipv6.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next v3] tcp: md5: check md5 signature without socket lock From: David Miller In-Reply-To: <20140807023822.dc786be51bcb7c22577f66e1@qrator.net> References: <20140807023822.dc786be51bcb7c22577f66e1@qrator.net> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Wed, 06 Aug 2014 16:00:57 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dmitry Popov Date: Thu, 7 Aug 2014 02:38:22 +0400 > Since a8afca032 (tcp: md5: protects md5sig_info with RCU) tcp_md5_do_lookup > doesn't require socket lock, rcu_read_lock is enough. Therefore socket lock is > no longer required for tcp_v{4,6}_inbound_md5_hash too, so we can move these > calls (wrapped with rcu_read_{,un}lock) before bh_lock_sock: > from tcp_v{4,6}_do_rcv to tcp_v{4,6}_rcv. > > Signed-off-by: Dmitry Popov Applied, thank you.