Re: [PATCH 1/1] spi: Remove unused definitions

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1240 bytes --]

On Wed, Aug 06, 2014 at 08:50:15PM +0200, Geert Uytterhoeven wrote:

> To be 100% sure, I tried to find with which kernel config this warning shows up.
> It doesn't happen for omap1_defconfig with CONFIG_SPI_OMAP_100K,
> which was the most likely culprit.

> It does happen with sparc/sparc64 allmodconfig. However, changing or
> removing the READ and WRITE definitions in drivers/spi/spi-omap-100k.c
> doesn't have any influence on the preprocessed source files
> ("make drivers/spi/spi-omap-100k.i", modulo line number changes),
> for both omap1 and sparc builds.

> (Nick: I believe the above is what people really want to see)

> So I conclude they are really not used, and they can be safely removed.

> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

Right, I'd already done the same analysis myself with looking for uses
myself (though I didn't go looking for how to trigger).  Nick, please do
look at the analysis Geert provided above - it is indeed exactly the
sort of thing that people would want to see, just saying what's in the
diff isn't enough especially given the well advertised quality problems
with your submissions.  You really need to explain why the change you're
making is a good idea.

I've applied the change.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]