From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755986AbaHGXHA (ORCPT ); Thu, 7 Aug 2014 19:07:00 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:53669 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751970AbaHGXGy (ORCPT ); Thu, 7 Aug 2014 19:06:54 -0400 Date: Thu, 07 Aug 2014 16:06:52 -0700 (PDT) Message-Id: <20140807.160652.1955607781047860694.davem@davemloft.net> To: himangi774@gmail.com Cc: tedheadster@gmail.com, paul.gortmaker@windriver.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, julia.lawall@lip6.fr Subject: Re: [PATCH] drivers/net: Remove typedefs pcnet_dev_t and hw_info_t From: David Miller In-Reply-To: <20140807204039.GA21415@himangi-Dell> References: <20140807204039.GA21415@himangi-Dell> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Thu, 07 Aug 2014 16:06:53 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Himangi Saraogi Date: Fri, 8 Aug 2014 02:10:39 +0530 > The Linux kernel coding style guidelines suggest not using typedefs > for structure types. This patch gets rid of the typedefs for pcnet_dev_t > and hw_info_t. Also, the name of the structs is changed to drop the _t, > to make the name look less typedef-like. > > The following Coccinelle semantic patch detects the cases: > Signed-off-by: Himangi Saraogi > Acked-by: Julia Lawall Applied.