From: Dmitry Popov <ixaphire@qrator.net>
To: David Miller <davem@davemloft.net>
Cc: yoshfuji@linux-ipv6.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2] tcp: md5: check md5 signature without socket lock
Date: Thu, 7 Aug 2014 02:33:47 +0400 [thread overview]
Message-ID: <20140807023347.ad7215e4c192672ef23ee3ac@qrator.net> (raw)
In-Reply-To: <20140806.145218.1742159418901363810.davem@davemloft.net>
On Wed, 06 Aug 2014 14:52:18 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
> From: Dmitry Popov <ixaphire@qrator.net>
> Date: Thu, 7 Aug 2014 01:49:53 +0400
>
> > Since a8afca032 (tcp: md5: protects md5sig_info with RCU) tcp_md5_do_lookup
> > doesn't require socket lock, rcu_read_lock is enough. Therefore socket lock is
> > no longer required for tcp_v{4,6}_inbound_md5_hash too, so we can move these
> > calls (wrapped with rcu_read_{,un}lock) before bh_lock_sock:
> > from tcp_v{4,6}_do_rcv to tcp_v{4,6}_rcv.
> >
> > Signed-off-by: Dmitry Popov <ixaphire@qrator.net>
>
> Please respin this against the current 'net' tree, it doesn't apply.
Oops, my bad, sorry. I will resubmit.
prev parent reply other threads:[~2014-08-06 22:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 21:49 Dmitry Popov
2014-08-06 21:52 ` David Miller
2014-08-06 22:33 ` Dmitry Popov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140807023347.ad7215e4c192672ef23ee3ac@qrator.net \
--to=ixaphire@qrator.net \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®