From: Peter Zijlstra <peterz@infradead.org>
To: Waiman Long <Waiman.Long@hp.com>
Cc: Ingo Molnar <mingo@kernel.org>,
Maarten Lankhorst <maarten.lankhorst@canonical.com>,
Rik van Riel <riel@redhat.com>,
linux-kernel@vger.kernel.org,
Scott J Norton <scott.norton@hp.com>,
Fengguang Wu <fengguang.wu@intel.com>
Subject: Re: [PATCH v7 2/2] locking/selftest: Support queued rwlock
Date: Thu, 7 Aug 2014 11:58:35 +0200 [thread overview]
Message-ID: <20140807095835.GM19379@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1407345722-61615-3-git-send-email-Waiman.Long@hp.com>
[-- Attachment #1: Type: text/plain, Size: 900 bytes --]
On Wed, Aug 06, 2014 at 01:22:02PM -0400, Waiman Long wrote:
> The queued rwlock does not support the use of recursive read-lock in
> the process context. With changes in the lockdep code to check and
> disallow recursive read-lock, it is also necessary for the locking
> selftest to be updated to change the process context recursive read
> locking results from SUCCESS to FAILURE for rwlock.
> +static void rlock_AHA1(void)
> +{
> + RL(X1);
> + HARDIRQ_ENTER();
> + RL(X1); // this one should NOT fail
> + HARDIRQ_EXIT();
> +}
> +
> +static void rlock_AHA1B(void)
> +{
> + RL(X1);
> + HARDIRQ_ENTER();
> + RL(X2); // this one should NOT fail
> + HARDIRQ_EXIT();
> +}
> +
> +static void rlock_ASAHA1(void)
> +{
> + RL(X1);
> + SOFTIRQ_ENTER();
> + RL(X1); // this one should NOT fail
> + HARDIRQ_ENTER();
> + RL(X1); // this one should NOT fail
> + HARDIRQ_EXIT();
> + SOFTIRQ_EXIT();
> }
Thanks!
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-08-07 9:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 17:22 [PATCH v7 0/2] lockdep: add support for " Waiman Long
2014-08-06 17:22 ` [PATCH v7 1/2] locking/lockdep: Restrict the use of recursive read_lock() with qrwlock Waiman Long
2014-08-13 10:56 ` [tip:locking/core] " tip-bot for Waiman Long
2014-08-06 17:22 ` [PATCH v7 2/2] locking/selftest: Support queued rwlock Waiman Long
2014-08-07 9:58 ` Peter Zijlstra [this message]
2014-08-13 10:57 ` [tip:locking/core] " tip-bot for Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140807095835.GM19379@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Waiman.Long@hp.com \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@canonical.com \
--cc=mingo@kernel.org \
--cc=riel@redhat.com \
--cc=scott.norton@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome