From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932323AbaHGNAw (ORCPT ); Thu, 7 Aug 2014 09:00:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41471 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757511AbaHGNAu (ORCPT ); Thu, 7 Aug 2014 09:00:50 -0400 Date: Thu, 7 Aug 2014 15:00:42 +0200 From: Karel Zak To: Boaz Harrosh Cc: Ross Zwisler , Boaz Harrosh , Jens Axboe , Matthew Wilcox , linux-kernel , linux-fsdevel Subject: Re: [PATCH 4/4] brd: Request from fdisk 4k alignment Message-ID: <20140807130042.GB9401@x2.net.home> References: <53E21125.9080308@plexistor.com> <53E21317.7080403@plexistor.com> <1407362634.2869.2.camel@rzwisler-mobl1.amr.corp.intel.com> <53E36E53.3090008@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53E36E53.3090008@gmail.com> User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 07, 2014 at 03:17:23PM +0300, Boaz Harrosh wrote: > > Is there an error case that this patch fixes? I've had page alignment checks > > in my PRD direct_access code forever, and I don't know if they've ever > > tripped. > > > > Yes! as I said above fix fdisk. You never tripped on it because partitions never > worked and you never tried them. With current code fdisk is very trigger happy What do you mean with fdisk? which version? The current fdisk (and cfdisk) follows I/O limits it has no problem with 4K devices. All you need is to provide all necessary information by /sys (or ioctls). > to miss-align my partitions. Depending on size maybe not the very first one but the > consecutive ones easily. it would be nice to have usable bug report... Karel -- Karel Zak http://karelzak.blogspot.com