From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933019AbaHGQrd (ORCPT ); Thu, 7 Aug 2014 12:47:33 -0400 Received: from mail-pd0-f170.google.com ([209.85.192.170]:39093 "EHLO mail-pd0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932330AbaHGQra (ORCPT ); Thu, 7 Aug 2014 12:47:30 -0400 Date: Thu, 7 Aug 2014 09:47:25 -0700 From: Dmitry Torokhov To: Javier Martinez Canillas Cc: Tomasz Figa , Nick Dyer , Stephen Warren , Yufeng Shen , Benson Leung , Doug Anderson , Olof Johansson , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] Input: atmel_mxt_ts - Get IRQ edge/level flags on DT booting Message-ID: <20140807164725.GA22421@core.coreip.homeip.net> References: <1407372486-25881-1-git-send-email-javier.martinez@collabora.co.uk> <53E2D2F8.7010606@gmail.com> <53E2DAAC.1060602@collabora.co.uk> <20140807060926.GA651@core.coreip.homeip.net> <53E32F9D.2080705@collabora.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53E32F9D.2080705@collabora.co.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 07, 2014 at 09:49:49AM +0200, Javier Martinez Canillas wrote: > Hello Dmitry, > > On 08/07/2014 08:09 AM, Dmitry Torokhov wrote: > >> > >> > irq_of_parse_and_map() already sets up IRQ trigger type based on DT > >> > data, by calling irq_create_of_mapping() which in turn calls > >> > irq_set_irq_type(). > >> > > >> > >> Right but somehow when the IRQ is actually requested the type is overwritten by > >> the value passed to request_threaded_irq() and interrupts are not being > >> generated by the device without this patch. > >> > >> Do you think that this is a bug in the "interrupt-parent" irqchip driver or the > >> IRQ core? I'm not that familiar with the IRQ subsystem. > > > > No, this is clearly driver fault - it smashed previously done setup with new > > flags. > > > > Thanks a lot for the clarification. That was my understanding as well but wanted > to be sure. Actually, I take this back. In mainline everything as it should: if pdata does not specify particular trigger the flags requested end up being IRQF_ONESHOT, which should preserve trigger bits previously set up by the board or OF code. In Chrome kernel we have: /* Default to falling edge if no platform data provided */ irqflags = data->pdata ? data->pdata->irqflags : IRQF_TRIGGER_FALLING; error = request_threaded_irq(client->irq, NULL, mxt_interrupt, irqflags | IRQF_ONESHOT, client->name, data); which I believe should go away. If it is needed on ACPI systems we need to figure out how to do things we can do with OF there. Thanks. -- Dmitry