From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Oleg Drokin <green@linuxhacker.ru>
Cc: Evgeny Budilovsky <budevg@gmail.com>,
devel@driverdev.osuosl.org,
Andreas Dilger <andreas.dilger@intel.com>,
Peng Tao <bergwolf@gmail.com>,
linux-kernel@vger.kernel.org, Lai Siyao <lai.siyao@intel.com>
Subject: Re: [PATCH] staging/lustre: use rcu_dereference to access rcu protected current->real_parent field
Date: Thu, 7 Aug 2014 21:42:46 -0700 [thread overview]
Message-ID: <20140808044246.GA3084@kroah.com> (raw)
In-Reply-To: <DFF36154-06AC-4D7E-87F5-259B73CB059B@linuxhacker.ru>
On Fri, Aug 08, 2014 at 12:03:20AM -0400, Oleg Drokin wrote:
> Hello!
>
> On Aug 7, 2014, at 11:49 PM, Greg Kroah-Hartman wrote:
> >>
> >> This is not a critical bug and in the worst case the code here may
> >> cause miss of statistics counter increase.
> >> This is why I think it is not worth to backport the patch at all.
> > You are right, and if this is just for some random "statistics" file,
> > can we just delete the whole function?
>
> I hope not!
> This is used all around the client to tally up various operations executed counts.
Why would you do that? Why would they care?
> The statistic is then used by various userspace monitoring tools.
Why not use the in-kernel monitoring tools instead of creating your own?
What does userspace do with that information?
thanks,
greg k-h
next prev parent reply other threads:[~2014-08-08 4:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 18:22 Evgeny Budilovsky
2014-08-06 21:42 ` Greg Kroah-Hartman
2014-08-07 11:13 ` Evgeny Budilovsky
2014-08-08 3:49 ` Greg Kroah-Hartman
2014-08-08 4:03 ` Oleg Drokin
2014-08-08 4:42 ` Greg Kroah-Hartman [this message]
2014-08-08 5:06 ` Oleg Drokin
2014-08-08 5:32 ` Greg Kroah-Hartman
2014-08-09 11:05 ` Peng Tao
2014-08-09 14:04 ` Greg Kroah-Hartman
2014-08-09 14:34 ` Oleg Drokin
2014-08-09 15:47 ` Greg Kroah-Hartman
2014-08-12 1:44 ` Oleg Drokin
2014-08-12 2:39 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140808044246.GA3084@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andreas.dilger@intel.com \
--cc=bergwolf@gmail.com \
--cc=budevg@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=green@linuxhacker.ru \
--cc=lai.siyao@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome