From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Juri Lelli <juri.lelli@arm.com>
Cc: linux-kernel@vger.kernel.org, lorenzo.pieralisi@arm.com,
Daniel Lezcano <daniel.lezcano@linaro.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Juri Lelli <juri.lelli@gmail.com>
Subject: Re: [PATCH] cpuidle/cpuidle-big_little: fix reading cpu id part number
Date: Fri, 8 Aug 2014 14:21:05 +0100 [thread overview]
Message-ID: <20140808132105.GB30282@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1407501757-15231-1-git-send-email-juri.lelli@arm.com>
On Fri, Aug 08, 2014 at 01:42:37PM +0100, Juri Lelli wrote:
> Commit af040ffc9ba1 ("ARM: make it easier to check the CPU part number
> correctly") changed ARM_CPU_PART_X masks, and the way they are returned and
> checked against. Usage of read_cpuid_part_number() is now deprecated, and
> calling places updated accordingly. This actually broke cpuidle-big_little
> initialization, as bl_idle_driver_init() performs a check using and hardcoded
> mask on cpu_id.
>
> Update the check to reflect changes on ARM_CPU_PART_X masks. Also,
> make the check easier to understand.
I don't like this "let's work out our own way to check the CPU type"
stuff which people seem to create. Let's try and do the job better
and have some proper interfaces to do this kind of thing.
Maybe we should have smp_cpuid_part(cpu) which returns the CPU vendor/
part identifier for the particular CPU in an efficient manner.
--
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2014-08-08 13:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-08 12:42 Juri Lelli
2014-08-08 13:21 ` Russell King - ARM Linux [this message]
2014-08-08 16:47 ` Lorenzo Pieralisi
2014-08-13 10:04 ` Juri Lelli
2014-08-13 10:44 ` Russell King - ARM Linux
2014-08-13 11:14 ` Juri Lelli
2014-08-13 22:25 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140808132105.GB30282@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=daniel.lezcano@linaro.org \
--cc=juri.lelli@arm.com \
--cc=juri.lelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®