From: Daeseok Youn <daeseok.youn@gmail.com>
To: akpm@linux-foundation.org
Cc: oleg@redhat.com, ebiederm@xmission.com, eparis@redhat.com,
rgb@redhat.com, tixxdz@opendz.org, adobriyan@gmail.com,
bill.c.roberts@gmail.com, linux-kernel@vger.kernel.org
Subject: [PATCH] proc: potential ERR_PTR dereference on proc_fill_cache()
Date: Mon, 11 Aug 2014 11:47:20 +0900 [thread overview]
Message-ID: <20140811024720.GA11337@devel.8.8.4.4> (raw)
The d_hash_and_lookup() returns NULL or ERR_PTR on lookup
failure.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
---
fs/proc/base.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/proc/base.c b/fs/proc/base.c
index f50d4be..49bc09c 100644
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -1673,7 +1673,7 @@ bool proc_fill_cache(struct file *file, struct dir_context *ctx,
ino_t ino;
child = d_hash_and_lookup(dir, &qname);
- if (!child) {
+ if (IS_ERR_OR_NULL(child)) {
child = d_alloc(dir, &qname);
if (!child)
goto end_instantiate;
--
1.7.1
next reply other threads:[~2014-08-11 2:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-11 2:47 Daeseok Youn [this message]
2014-08-11 3:25 ` Eric W. Biederman
2014-08-11 5:43 ` DaeSeok Youn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140811024720.GA11337@devel.8.8.4.4 \
--to=daeseok.youn@gmail.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bill.c.roberts@gmail.com \
--cc=ebiederm@xmission.com \
--cc=eparis@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=rgb@redhat.com \
--cc=tixxdz@opendz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®