From: Alexander Gordeev <agordeev@redhat.com>
To: linux-kernel@vger.kernel.org, Christoph Hellwig <hch@infradead.org>
Cc: Naresh Kumar Inna <naresh@chelsio.com>,
Arvind Bhushan <arvindb@chelsio.com>,
linux-scsi@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v2 RESEND 06/23] csiostor: Use pci_enable_msix_range() instead of pci_enable_msix()
Date: Mon, 11 Aug 2014 09:49:18 +0200 [thread overview]
Message-ID: <20140811074916.GD16504@dhcp-27-160.brq.redhat.com> (raw)
In-Reply-To: <66f5bda4546f61484a27570f9971fdb6683210da.1405533479.git.agordeev@redhat.com>
On Wed, Jul 16, 2014 at 08:05:10PM +0200, Alexander Gordeev wrote:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi_range() or pci_enable_msi_exact()
> and pci_enable_msix_range() or pci_enable_msix_exact()
> interfaces.
Christoph,
This driver does not have maintainers in Chelsio anymore.
> Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
> Cc: Naresh Kumar Inna <naresh@chelsio.com>
> Cc: Arvind Bhushan <arvindb@chelsio.com>
> Cc: linux-scsi@vger.kernel.org
> Cc: linux-pci@vger.kernel.org
> ---
> drivers/scsi/csiostor/csio_hw.h | 2 +-
> drivers/scsi/csiostor/csio_isr.c | 22 +++++++++-------------
> 2 files changed, 10 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/scsi/csiostor/csio_hw.h b/drivers/scsi/csiostor/csio_hw.h
> index 49b1daa..5db2d85 100644
> --- a/drivers/scsi/csiostor/csio_hw.h
> +++ b/drivers/scsi/csiostor/csio_hw.h
> @@ -94,7 +94,7 @@ enum {
> };
>
> struct csio_msix_entries {
> - unsigned short vector; /* Vector assigned by pci_enable_msix */
> + unsigned short vector; /* Assigned MSI-X vector */
> void *dev_id; /* Priv object associated w/ this msix*/
> char desc[24]; /* Description of this vector */
> };
> diff --git a/drivers/scsi/csiostor/csio_isr.c b/drivers/scsi/csiostor/csio_isr.c
> index 91ba91d..a8c748a 100644
> --- a/drivers/scsi/csiostor/csio_isr.c
> +++ b/drivers/scsi/csiostor/csio_isr.c
> @@ -499,7 +499,7 @@ csio_reduce_sqsets(struct csio_hw *hw, int cnt)
> static int
> csio_enable_msix(struct csio_hw *hw)
> {
> - int rv, i, j, k, n, min, cnt;
> + int i, j, k, n, min, cnt;
> struct csio_msix_entries *entryp;
> struct msix_entry *entries;
> int extra = CSIO_EXTRA_VECS;
> @@ -521,19 +521,15 @@ csio_enable_msix(struct csio_hw *hw)
>
> csio_dbg(hw, "FW supp #niq:%d, trying %d msix's\n", hw->cfg_niq, cnt);
>
> - while ((rv = pci_enable_msix(hw->pdev, entries, cnt)) >= min)
> - cnt = rv;
> - if (!rv) {
> - if (cnt < (hw->num_sqsets + extra)) {
> - csio_dbg(hw, "Reducing sqsets to %d\n", cnt - extra);
> - csio_reduce_sqsets(hw, cnt - extra);
> - }
> - } else {
> - if (rv > 0)
> - csio_info(hw, "Not using MSI-X, remainder:%d\n", rv);
> -
> + cnt = pci_enable_msix_range(hw->pdev, entries, min, cnt);
> + if (cnt < 0) {
> kfree(entries);
> - return -ENOMEM;
> + return cnt;
> + }
> +
> + if (cnt < (hw->num_sqsets + extra)) {
> + csio_dbg(hw, "Reducing sqsets to %d\n", cnt - extra);
> + csio_reduce_sqsets(hw, cnt - extra);
> }
>
> /* Save off vectors */
> --
> 1.7.7.6
>
next prev parent reply other threads:[~2014-08-11 7:49 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 18:05 [PATCH v2 RESEND 00/23] scsi: " Alexander Gordeev
2014-07-16 18:05 ` [PATCH v2 RESEND 01/23] be2iscsi: Use pci_enable_msix_exact() " Alexander Gordeev
2014-07-26 8:08 ` Alexander Gordeev
2014-07-28 23:29 ` Jayamohan Kallickal
2014-08-11 7:34 ` Alexander Gordeev
2014-07-16 18:05 ` [PATCH v2 RESEND 02/23] bfa: Do not call pci_enable_msix() after it failed once Alexander Gordeev
2014-07-16 18:05 ` [PATCH v2 RESEND 03/23] bfa: Cleanup bfad_setup_intr() function Alexander Gordeev
2014-07-16 18:05 ` [PATCH v2 RESEND 04/23] bfa: Use pci_enable_msix_exact() instead of pci_enable_msix() Alexander Gordeev
2014-08-11 7:39 ` Alexander Gordeev
2014-08-11 11:02 ` Anil Gurumurthy
2014-08-12 10:50 ` Alexander Gordeev
2014-08-14 2:55 ` Anil Gurumurthy
2014-07-16 18:05 ` [PATCH v2 RESEND 05/23] csiostor: Remove superfluous call to pci_disable_msix() Alexander Gordeev
2014-07-26 8:13 ` Alexander Gordeev
2014-07-16 18:05 ` [PATCH v2 RESEND 06/23] csiostor: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-08-11 7:49 ` Alexander Gordeev [this message]
2014-07-16 18:05 ` [PATCH v2 RESEND 07/23] fnic: Use pci_enable_msix_exact() " Alexander Gordeev
2014-07-26 8:15 ` Alexander Gordeev
2014-07-28 8:08 ` Suma Ramars (sramars)
2014-07-16 18:05 ` [PATCH v2 RESEND 08/23] hpsa: Fallback to MSI rather than to INTx if MSI-X failed Alexander Gordeev
2014-07-26 8:16 ` Alexander Gordeev
2014-08-11 7:53 ` Alexander Gordeev
2014-08-13 16:04 ` scameron
2014-08-13 17:05 ` Alexander Gordeev
2014-07-16 18:05 ` [PATCH v2 RESEND 09/23] hpsa: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-08-15 15:48 ` scameron
2014-07-16 18:05 ` [PATCH v2 RESEND 10/23] isci: Use pci_enable_msix_exact() " Alexander Gordeev
2014-07-16 18:05 ` [PATCH v2 RESEND 11/23] lpfc: Remove superfluous call to pci_disable_msix() Alexander Gordeev
2014-07-16 18:05 ` [PATCH v2 RESEND 12/23] lpfc: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-07-26 8:22 ` Alexander Gordeev
2014-08-11 8:01 ` Alexander Gordeev
2014-08-11 17:14 ` James Smart
2014-08-12 8:11 ` Alexander Gordeev
2014-08-12 8:09 ` [PATCH v3 " Alexander Gordeev
2014-07-16 18:05 ` [PATCH v2 RESEND 13/23] megaraid: Fail resume if MSI-X re-initialization failed Alexander Gordeev
2014-07-26 8:24 ` Alexander Gordeev
2014-07-28 5:56 ` Kashyap Desai
2014-08-11 8:07 ` Alexander Gordeev
2014-07-16 18:05 ` [PATCH v2 RESEND 14/23] megaraid: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-08-11 8:09 ` Alexander Gordeev
2014-08-11 8:29 ` Kashyap Desai
2014-07-16 18:05 ` [PATCH v2 RESEND 15/23] mpt2sas: Use pci_enable_msix_exact() " Alexander Gordeev
2014-07-26 8:26 ` Alexander Gordeev
2014-08-11 13:07 ` Tomas Henzl
2014-07-16 18:05 ` [PATCH v2 RESEND 16/23] mpt3sas: " Alexander Gordeev
2014-08-11 8:13 ` Alexander Gordeev
2014-08-11 13:07 ` Tomas Henzl
2014-07-16 18:05 ` [PATCH v2 RESEND 17/23] pm8001: Fix invalid return when request_irq() failed Alexander Gordeev
2014-07-29 13:13 ` Tomas Henzl
2014-07-29 13:20 ` Christoph Hellwig
2014-07-29 13:48 ` Tomas Henzl
2014-07-29 13:56 ` Christoph Hellwig
2014-07-29 14:15 ` Alexander Gordeev
2014-07-29 14:24 ` Christoph Hellwig
2014-08-11 8:14 ` Alexander Gordeev
2014-07-16 18:05 ` [PATCH v2 RESEND 18/23] pm8001: Use pci_enable_msix_exact() instead of pci_enable_msix() Alexander Gordeev
2014-07-26 8:33 ` Alexander Gordeev
2014-07-27 10:29 ` Jack Wang
2014-07-16 18:05 ` [PATCH v2 RESEND 19/23] pmcraid: Get rid of a redundant assignment Alexander Gordeev
2014-07-16 18:05 ` [PATCH v2 RESEND 20/23] pmcraid: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-07-26 8:37 ` Alexander Gordeev
2014-07-16 18:05 ` [PATCH v2 RESEND 21/23] qla2xxx: " Alexander Gordeev
2014-07-26 8:40 ` Alexander Gordeev
2014-08-11 8:57 ` Alexander Gordeev
2014-08-11 18:07 ` Chad Dupuis
2014-07-16 18:05 ` [PATCH v2 RESEND 22/23] qla4xxx: Use pci_enable_msix_exact() " Alexander Gordeev
2014-07-26 8:41 ` Alexander Gordeev
2014-07-28 11:47 ` Vikas Chaudhary
2014-08-11 8:54 ` Alexander Gordeev
2014-08-11 9:40 ` Christoph Hellwig
2014-07-16 18:05 ` [PATCH v2 RESEND 23/23] vmw_pvscsi: " Alexander Gordeev
2014-07-16 18:23 ` Arvind Kumar
2014-07-17 20:28 ` [PATCH v2 RESEND 00/23] scsi: Use pci_enable_msix_range() " Christoph Hellwig
2014-07-29 12:38 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2014-04-14 8:05 Alexander Gordeev
2014-04-14 8:05 ` [PATCH v2 RESEND 06/23] csiostor: " Alexander Gordeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140811074916.GD16504@dhcp-27-160.brq.redhat.com \
--to=agordeev@redhat.com \
--cc=arvindb@chelsio.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=naresh@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®