From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752142AbaHKIHs (ORCPT ); Mon, 11 Aug 2014 04:07:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20070 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751331AbaHKIHq (ORCPT ); Mon, 11 Aug 2014 04:07:46 -0400 Date: Mon, 11 Aug 2014 10:07:16 +0200 From: Alexander Gordeev To: Christoph Hellwig Cc: Kashyap Desai , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH v2 RESEND 13/23] megaraid: Fail resume if MSI-X re-initialization failed Message-ID: <20140811080714.GH16504@dhcp-27-160.brq.redhat.com> References: <3d2402ebfad625e508bb13257e1560abf92594cd.1405533479.git.agordeev@redhat.com> <20140726082408.GG21129@agordeev.usersys.redhat.com> <3b7c554551d306e2f58f5e09dc171db2@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3b7c554551d306e2f58f5e09dc171db2@mail.gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 28, 2014 at 11:26:13AM +0530, Kashyap Desai wrote: > > -----Original Message----- > > From: Alexander Gordeev [mailto:agordeev@redhat.com] > > Sent: Saturday, July 26, 2014 1:54 PM > > To: linux-kernel@vger.kernel.org; Neela Syam Kolli > > Subject: Re: [PATCH v2 RESEND 13/23] megaraid: Fail resume if MSI-X re- > > initialization failed > > > > On Wed, Jul 16, 2014 at 08:05:17PM +0200, Alexander Gordeev wrote: > > > Currently the driver fails to analize MSI-X re-enablement status on > > > resuming and always assumes the success. This update checks the MSI-X > > > initialization result and fails to resume if MSI-Xs re-enablement > > > failed. > > > > Hi Neela, > > > > Could you please review megaraid patches in this series? > > > > Thanks! > Please consider this patch Acked by Me. > > Acked-by: Kashyap Desai Christoph, I guess, this patch could be picked? > > > > > Signed-off-by: Alexander Gordeev > > > --- > > > drivers/scsi/megaraid/megaraid_sas_base.c | 8 +++++--- > > > 1 files changed, 5 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c > > > b/drivers/scsi/megaraid/megaraid_sas_base.c > > > index 112799b..ba06102 100644 > > > --- a/drivers/scsi/megaraid/megaraid_sas_base.c > > > +++ b/drivers/scsi/megaraid/megaraid_sas_base.c > > > @@ -5134,9 +5134,10 @@ megasas_resume(struct pci_dev *pdev) > > > goto fail_ready_state; > > > > > > /* Now re-enable MSI-X */ > > > - if (instance->msix_vectors) > > > - pci_enable_msix(instance->pdev, instance->msixentry, > > > - instance->msix_vectors); > > > + if (instance->msix_vectors && > > > + pci_enable_msix(instance->pdev, instance->msixentry, > > > + instance->msix_vectors)) > > > + goto fail_reenable_msix; > > > > > > switch (instance->pdev->device) { > > > case PCI_DEVICE_ID_LSI_FUSION: > > > @@ -5245,6 +5246,7 @@ fail_init_mfi: > > > > > > fail_set_dma_mask: > > > fail_ready_state: > > > +fail_reenable_msix: > > > > > > pci_disable_device(pdev); > > > > > > -- > > > 1.7.7.6 > > > > > > > -- > > Regards, > > Alexander Gordeev > > agordeev@redhat.com