mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Preeti U Murthy <preeti@linux.vnet.ibm.com>
To: alex.shi@intel.com, vincent.guittot@linaro.org,
	peterz@infradead.org, pjt@google.com, efault@gmx.de,
	rjw@rjwysocki.net, morten.rasmussen@arm.com,
	svaidy@linux.vnet.ibm.com, arjan@linux.intel.com,
	mingo@kernel.org
Cc: nicolas.pitre@linaro.org, len.brown@intel.com,
	yuyang.du@intel.com, linaro-kernel@lists.linaro.org,
	daniel.lezcano@linaro.org, corbet@lwn.net,
	catalin.marinas@arm.com, markgross@thegnar.org,
	sundar.iyer@intel.com, linux-kernel@vger.kernel.org,
	dietmar.eggemann@arm.com, Lorenzo.Pieralisi@arm.com,
	mike.turquette@linaro.org, akpm@linux-foundation.org,
	paulmck@linux.vnet.ibm.com, tglx@linutronix.de
Subject: [RFC PATCH V2 19/19] sched: don't do power balance on share cpu power domain
Date: Mon, 11 Aug 2014 17:20:20 +0530	[thread overview]
Message-ID: <20140811115000.32407.53101.stgit@preeti.in.ibm.com> (raw)
In-Reply-To: <20140811114501.32407.61304.stgit@preeti.in.ibm.com>

From: Alex Shi <alex.shi@intel.com>

Packing tasks among such domain can't save power, just performance
losing. So no power balance on them.

Signed-off-by: Alex Shi <alex.shi@intel.com>
[Added CONFIG_SCHED_POWER switch to enable this patch]
Signed-off-by: Preeti U Murthy <preeti@linux.vnet.ibm.com>
---

 kernel/sched/fair.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index c49ee6c..adda9cf 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -4744,7 +4744,7 @@ static int get_cpu_for_power_policy(struct sched_domain *sd, int cpu,
 
 	policy = get_sd_sched_balance_policy(sd, cpu, p, sds);
 	if (policy != SCHED_POLICY_PERFORMANCE && sds->group_leader) {
-		if (wakeup)
+		if (wakeup && !(sd->flags & SD_SHARE_CPUCAPACITY))
 			new_cpu = find_leader_cpu(sds->group_leader,
 							p, cpu, policy);
 		/* for fork balancing and a little busy task */
@@ -5882,8 +5882,9 @@ static inline void init_sd_lb_stats(struct sd_lb_stats *sds)
 static inline void init_sd_lb_power_stats(struct lb_env *env,
 						struct sd_lb_stats *sds)
 {
-	if (sched_balance_policy == SCHED_POLICY_PERFORMANCE ||
-				env->idle == CPU_NOT_IDLE) {
+	if (sched_balance_policy == SCHED_POLICY_PERFORMANCE
+			|| env->sd->flags & SD_SHARE_CPUCAPACITY
+			|| env->idle == CPU_NOT_IDLE) {
 		env->flags &= ~LBF_POWER_BAL;
 		env->flags |= LBF_PERF_BAL;
 		return;


      parent reply	other threads:[~2014-08-11 11:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-11 11:48 [RFC PATCH V2 17/19] sched: power aware load balance Preeti U Murthy
2014-08-11 11:49 ` [RFC PATCH V2 18/19] sched: lazy power balance Preeti U Murthy
2014-08-11 11:50 ` Preeti U Murthy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140811115000.32407.53101.stgit@preeti.in.ibm.com \
    --to=preeti@linux.vnet.ibm.com \
    --cc=Lorenzo.Pieralisi@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=alex.shi@intel.com \
    --cc=arjan@linux.intel.com \
    --cc=catalin.marinas@arm.com \
    --cc=corbet@lwn.net \
    --cc=daniel.lezcano@linaro.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=efault@gmx.de \
    --cc=len.brown@intel.com \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markgross@thegnar.org \
    --cc=mike.turquette@linaro.org \
    --cc=mingo@kernel.org \
    --cc=morten.rasmussen@arm.com \
    --cc=nicolas.pitre@linaro.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=pjt@google.com \
    --cc=rjw@rjwysocki.net \
    --cc=sundar.iyer@intel.com \
    --cc=svaidy@linux.vnet.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=vincent.guittot@linaro.org \
    --cc=yuyang.du@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®