From: Mark Brown <broonie@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linaro-kernel <linaro-kernel@lists.linaro.org>
Subject: Re: [PATCH] gpiolib: Don't allow drivers to specify a base with DT
Date: Mon, 11 Aug 2014 13:31:46 +0100 [thread overview]
Message-ID: <20140811123146.GA17528@sirena.org.uk> (raw)
In-Reply-To: <CACRpkdaD2K4L+dF3iaXqQTsYJpoVRnRnp-4La38BWC3cRVUm7g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 616 bytes --]
On Mon, Aug 11, 2014 at 09:26:49AM +0200, Linus Walleij wrote:
> On Thu, Jul 31, 2014 at 2:07 PM, Mark Brown <broonie@kernel.org> wrote:
> > - if (base < 0) {
> > + if (base < 0 || of_have_populated_dt()) {
> > base = gpiochip_find_base(chip->ngpio);
> But here I worry about breaking in-transition systems, e.g.
> defining part of the peripherals through DT but adding a
> GPIO device with AUXDATA, setting up base that way.
> Not that it should stay that way for sure, but it does need
> some consideration...
Could we add a flag that the boards can use to override this behaviour?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2014-08-11 12:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 12:07 Mark Brown
2014-08-04 4:21 ` Alexandre Courbot
2014-08-11 12:38 ` Mark Brown
2014-08-11 7:26 ` Linus Walleij
2014-08-11 12:31 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140811123146.GA17528@sirena.org.uk \
--to=broonie@kernel.org \
--cc=gnurou@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®