From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>
Subject: Re: [PATCH 2/8] perf tools: Make __hpp__fmt() receive an additional len argument
Date: Mon, 11 Aug 2014 10:17:38 -0300 [thread overview]
Message-ID: <20140811131738.GB3277@kernel.org> (raw)
In-Reply-To: <87r40nfo36.fsf@sejong.aot.lge.com>
Em Mon, Aug 11, 2014 at 05:05:33PM +0900, Namhyung Kim escreveu:
> Hi Arnaldo,
>
> On Sat, 2 Aug 2014 10:30:26 -0300, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Jul 31, 2014 at 02:47:36PM +0900, Namhyung Kim escreveu:
> >> So that it can properly handle alignment requirements later. To do
> >> that, add percent_color_len_snprintf() fucntion to help coloring of
> >> overhead columns.
> >
> > Can you elaborate on this description? What is not possible to do before
> > this patch?
>
> This patch is a preparation that moves hard-coded print width out of the
> format string so that it can be passed from external settings later.
Ok, please add this to the patch description?
> > Perhaps a formatted line before this patch and then the same line
> > formatted after the patch?
> The default behavior wasn't changed, it's only meaningful when user
> gives field width using -w option. You can see the difference in the
> description 0/8.
- Arnaldo
next prev parent reply other threads:[~2014-08-11 13:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 5:47 [PATCHSET 0/8] perf tools: Honor column width setting (v3) Namhyung Kim
2014-07-31 5:47 ` [PATCH 1/8] perf tools: Left-align output contents Namhyung Kim
2014-08-13 5:17 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-07-31 5:47 ` [PATCH 2/8] perf tools: Make __hpp__fmt() receive an additional len argument Namhyung Kim
2014-08-02 13:30 ` Arnaldo Carvalho de Melo
2014-08-11 8:05 ` Namhyung Kim
2014-08-11 13:17 ` Arnaldo Carvalho de Melo [this message]
2014-08-12 7:13 ` Namhyung Kim
2014-08-13 5:18 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-07-31 5:47 ` [PATCH 3/8] perf tools: Save column length in perf_hpp_fmt Namhyung Kim
2014-08-13 5:18 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-07-31 5:47 ` [PATCH 4/8] perf report: Honor column width setting Namhyung Kim
2014-08-13 5:18 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-07-31 5:47 ` [PATCH 5/8] perf top: Add -w option for setting column width Namhyung Kim
2014-08-13 5:18 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-07-31 5:47 ` [PATCH 6/8] perf tools: Add name field into perf_hpp_fmt Namhyung Kim
2014-08-13 5:19 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-07-31 5:47 ` [PATCH 7/8] perf tools: Fix column alignment when headers aren't shown on TUI Namhyung Kim
2014-08-13 5:19 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-07-31 5:47 ` [PATCH 8/8] perf symbol: Don't demangle parameters and such by default Namhyung Kim
2014-08-02 13:35 ` Arnaldo Carvalho de Melo
2014-08-11 8:17 ` Namhyung Kim
2014-08-11 13:32 ` Arnaldo Carvalho de Melo
2014-08-12 7:17 ` Namhyung Kim
2014-08-14 8:49 ` [tip:perf/core] perf symbols: Don' t " tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140811131738.GB3277@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome