From: Mark Brown <broonie@kernel.org>
To: Axel Lin <axel.lin@ingics.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: Add stub function for devm_regulator_get_exclusive
Date: Mon, 11 Aug 2014 19:58:49 +0100 [thread overview]
Message-ID: <20140811185849.GK17528@sirena.org.uk> (raw)
In-Reply-To: <1407557707.21696.1.camel@phoenix>
[-- Attachment #1: Type: text/plain, Size: 485 bytes --]
On Sat, Aug 09, 2014 at 12:15:07PM +0800, Axel Lin wrote:
> static inline struct regulator *__must_check
> +devm_regulator_get_exclusive(struct device *dev, const char *id)
> +{
> + return NULL;
> +}
> +
> +static inline struct regulator *__must_check
This should be returning an error pointer, something wanting exclusive
control of a regulator would normally expect to have an actual regulator
and want to do things with it and so probably won't work well with a
dummy regulator.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2014-08-11 18:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-09 4:15 Axel Lin
2014-08-11 18:58 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140811185849.GK17528@sirena.org.uk \
--to=broonie@kernel.org \
--cc=axel.lin@ingics.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®