mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Pranith Kumar <bobby.prani@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>,
	"open list:SCHEDULER" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched: Remove ACCESS_ONCE() for jiffies
Date: Tue, 12 Aug 2014 07:55:27 +0200	[thread overview]
Message-ID: <20140812055527.GI9918@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1407797503-24727-3-git-send-email-bobby.prani@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 256 bytes --]

On Mon, Aug 11, 2014 at 06:51:41PM -0400, Pranith Kumar wrote:
> jiffies is declared as a volatile variable. Therefore it is not neccessary to
> use ACCESS_ONCE() while reading it.

It also doesn't hurt and it documents intent, so I'm inclined to keep
it.

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2014-08-12  5:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-11 22:51 [PATCH] doc: memory-barriers.txt: Minor correction in Control dependencies Pranith Kumar
2014-08-11 22:51 ` [PATCH] doc: memory-barriers.txt: Add barrier() to provide ordering Pranith Kumar
2014-08-13 22:50   ` Paul E. McKenney
2014-08-11 22:51 ` [PATCH] sched: Remove ACCESS_ONCE() for jiffies Pranith Kumar
2014-08-12  5:55   ` Peter Zijlstra [this message]
2014-08-12 14:42     ` Pranith Kumar
2014-08-12 22:11       ` David Rientjes
2014-08-11 22:51 ` [PATCH] compiler.h: Move __memory_barrier() use to compiler-intel.h Pranith Kumar
2014-08-13 22:49 ` [PATCH] doc: memory-barriers.txt: Minor correction in Control dependencies Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140812055527.GI9918@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=bobby.prani@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome