From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Lan Tianyu <tianyu.lan@intel.com>
Cc: wsa@the-dreams.de, torvalds@linux-foundation.org,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] I2C: Make I2C core able to be module when I2C_ACPI is selected.
Date: Tue, 12 Aug 2014 12:53:21 +0300 [thread overview]
Message-ID: <20140812095321.GU1657@lahna.fi.intel.com> (raw)
In-Reply-To: <1407740455-21269-1-git-send-email-tianyu.lan@intel.com>
On Mon, Aug 11, 2014 at 03:00:55PM +0800, Lan Tianyu wrote:
> Commit da3c6647(I2C/ACPI: Clean up I2C ACPI code and Add CONFIG_I2C_ACPI
> config) adds a new kernel config I2C_ACPI and make I2C core built in
> when the config is selected. This is wrong because distributions
> etc generally compile I2C as a module and the commit broken that.
> This patch is to make I2C core able to be a module when I2C_ACPI is
> selected. Original issue the commit da3c6647 tried to avoid will
> be fixed in ACPICA and it's rarely triggered during unloading module.
>
> Signed-off-by: Lan Tianyu <tianyu.lan@intel.com>
I wonder if we can do
depends on I2C=y
here? If I understand it right, then we only build the ACPI_I2C if I2C
is compiled into the kernel. That way the problem da3c6647 tried to
solve doens't re-appear.
We can later on relax this once ACPICA has been fixed. Thoughts?
next prev parent reply other threads:[~2014-08-12 9:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-11 7:00 Lan Tianyu
2014-08-12 9:53 ` Mika Westerberg [this message]
2014-08-13 2:03 ` Wolfram Sang
2014-08-13 2:50 ` Lan Tianyu
2014-08-13 7:07 ` Mika Westerberg
2014-08-13 7:22 ` Lan Tianyu
2014-08-14 9:37 ` Wolfram Sang
2014-08-15 5:38 ` [PATCH V2] I2C: Rework kernel config I2C_ACPI Lan Tianyu
2014-08-15 8:25 ` Mika Westerberg
2014-08-15 11:03 ` Wolfram Sang
2014-08-18 1:59 ` Lan Tianyu
2014-08-19 14:44 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140812095321.GU1657@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tianyu.lan@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome