From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753019AbaHLOM4 (ORCPT ); Tue, 12 Aug 2014 10:12:56 -0400 Received: from gw-1.arm.linux.org.uk ([78.32.30.217]:47786 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752915AbaHLOMw (ORCPT ); Tue, 12 Aug 2014 10:12:52 -0400 Date: Tue, 12 Aug 2014 15:12:43 +0100 From: Russell King - ARM Linux To: Srinivas Kandagatla Cc: linux-mmc@vger.kernel.org, Linus Walleij , Chris Ball , Ulf Hansson , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH RFC 3/5] mmc: mmci: relax blksz check for SDIO Message-ID: <20140812141242.GI30401@n2100.arm.linux.org.uk> References: <1407844950-8072-1-git-send-email-srinivas.kandadgatla@linaro.org> <1407845080-8353-1-git-send-email-srinivas.kandadgatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1407845080-8353-1-git-send-email-srinivas.kandadgatla@linaro.org> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 12, 2014 at 01:04:40PM +0100, Srinivas Kandagatla wrote: > From: Srinivas Kandagatla > > This patch adds condition in mmci_validate_data to skip checking > blocksize for SDIO card types. SDIO card type can issue blocksizes > which are not exactly power of 2 so this check always fails, resulting > in SDIO failures. Do you understand why this check is there? Do you realise that the standard MMCI from ARM Ltd can /only/ perform power-of-2 block transfers? Hence, NAK on this change as it stands. -- FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up according to speedtest.net.