mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: Peter Chan <peter.chan@freescale.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"tiwai@suse.de" <tiwai@suse.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"patches@opensource.wolfsonmicro.com" 
	<patches@opensource.wolfsonmicro.com>,
	"shengjiu.wang@freescale.com" <shengjiu.wang@freescale.com>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	Nicolin Chen <nicoleotsuka@gmail.com>,
	"guangyu.chen@freescale.com" <guangyu.chen@freescale.com>,
	"rf@opensource.wolfsonmicro.com" <rf@opensource.wolfsonmicro.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: wm8962: Correct the bit offset to enable mono speaker output
Date: Tue, 12 Aug 2014 22:57:42 +0100	[thread overview]
Message-ID: <20140812215742.GE17528@sirena.org.uk> (raw)
In-Reply-To: <20140812082416.GA15833@opensource.wolfsonmicro.com>

[-- Attachment #1: Type: text/plain, Size: 716 bytes --]

On Tue, Aug 12, 2014 at 09:24:16AM +0100, Charles Keepax wrote:
> On Mon, Aug 11, 2014 at 02:19:49PM +0100, Charles Keepax wrote:

> > From the wording of "tie both outputs together" in the datasheet
> > I would assume that means both should be fed the same audio? Was
> > this done? I will try to give the hardware guys here a shout and
> > see if I can get some clarification on mono mode on this device.

> I have had a word with the hardware team here and both channels
> do need to be enabled but audio should only be fed to the left
> channel. So the driver definitely needs updated for the mono
> case, but I am unclear as to what is causing your poor audio
> quality issue.

Overdriving the speaker perhaps?

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2014-08-12 21:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-07 11:55 Nicolin Chen
2014-08-07 16:58 ` Mark Brown
2014-08-08  8:20   ` [alsa-devel] " Nicolin Chen
2014-08-08  9:55     ` Peter Chan
2014-08-11 13:19       ` Charles Keepax
2014-08-12  8:24         ` Charles Keepax
2014-08-12 21:57           ` Mark Brown [this message]
2014-08-13 10:10             ` Peter Chan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140812215742.GE17528@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=ckeepax@opensource.wolfsonmicro.com \
    --cc=guangyu.chen@freescale.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicoleotsuka@gmail.com \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=peter.chan@freescale.com \
    --cc=rf@opensource.wolfsonmicro.com \
    --cc=shengjiu.wang@freescale.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®