mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: mroos@linux.ee
Cc: aaro.koskinen@iki.fi, sparclinux@vger.kernel.org,
	linux-kernel@vger.kernel.org, hughd@google.com,
	cat.schulze@alice-dsl.net
Subject: Re: sparc64 WARNING: at mm/mmap.c:2757 exit_mmap+0x13c/0x160()
Date: Wed, 13 Aug 2014 12:46:11 -0700 (PDT)	[thread overview]
Message-ID: <20140813.124611.767426770013677.davem@davemloft.net> (raw)
In-Reply-To: <alpine.SOC.1.00.1408131327250.18696@math.ut.ee>

From: Meelis Roos <mroos@linux.ee>
Date: Wed, 13 Aug 2014 14:44:42 +0300 (EEST)

> Did not test current git more.

Current git fails to boot without this fix which I posted the other
day:

====================
[PATCH 1/2] sparc64: Do not disable interrupts in nmi_cpu_busy()

nmi_cpu_busy() is a SMP function call that just makes sure that all of the
cpus are spinning using cpu cycles while the NMI test runs.

It does not need to disable IRQs because we just care about NMIs executing
which will even with 'normal' IRQs disabled.

It is not legal to enable hard IRQs in a SMP cross call, in fact this bug
triggers the BUG check in irq_work_run_list():

	BUG_ON(!irqs_disabled());

Because now irq_work_run() is invoked from the tail of
generic_smp_call_function_single_interrupt().

Signed-off-by: David S. Miller <davem@davemloft.net>
---
 arch/sparc/kernel/nmi.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/sparc/kernel/nmi.c b/arch/sparc/kernel/nmi.c
index 3370945..5b1151d 100644
--- a/arch/sparc/kernel/nmi.c
+++ b/arch/sparc/kernel/nmi.c
@@ -130,7 +130,6 @@ static inline unsigned int get_nmi_count(int cpu)
 
 static __init void nmi_cpu_busy(void *data)
 {
-	local_irq_enable_in_hardirq();
 	while (endflag == 0)
 		mb();
 }
-- 
1.7.11.7


  reply	other threads:[~2014-08-13 19:46 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-16 21:06 Meelis Roos
2013-06-17  5:32 ` Aaro Koskinen
2013-06-17  5:58   ` Aaro Koskinen
2013-08-03 20:40     ` David Miller
2013-10-22 17:46       ` Aaro Koskinen
2013-10-22 17:54         ` David Miller
2014-04-14 18:43           ` Aaro Koskinen
2014-04-14 18:58             ` David Miller
2014-04-16 18:58             ` David Miller
2014-04-16 22:22               ` mroos
2014-04-16 22:49                 ` David Miller
2014-07-29 23:26                 ` David Miller
2014-07-30 22:02                   ` Meelis Roos
2014-07-30 22:07                     ` David Miller
2014-08-13 11:44                       ` Meelis Roos
2014-08-13 19:46                         ` David Miller [this message]
2014-08-14 12:20                           ` Meelis Roos
2014-08-15 12:42                           ` Meelis Roos
2014-08-18 12:30                             ` Meelis Roos
2014-08-18 17:35                               ` Aaro Koskinen
2014-08-18 17:38                                 ` David Miller
2014-08-30 22:27                                   ` Aaro Koskinen
2014-08-18 23:45                                 ` Julian Calaby
2014-08-19 21:29                                   ` Aaro Koskinen
2014-08-19  8:22                   ` Meelis Roos
2014-04-25 20:09               ` Aaro Koskinen
2014-04-25 20:17                 ` David Miller
2014-05-24 20:02                   ` mroos
2014-05-24 21:08                     ` David Miller
2014-06-09  6:36                       ` Meelis Roos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140813.124611.767426770013677.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=aaro.koskinen@iki.fi \
    --cc=cat.schulze@alice-dsl.net \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mroos@linux.ee \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®