From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751866AbaHMJ1E (ORCPT ); Wed, 13 Aug 2014 05:27:04 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56869 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751457AbaHMJ1C (ORCPT ); Wed, 13 Aug 2014 05:27:02 -0400 Date: Wed, 13 Aug 2014 11:26:59 +0200 From: Michal Hocko To: Cong Wang Cc: LKML , David Rientjes , "Rafael J. Wysocki" , Tejun Heo , Andrew Morton Subject: Re: [Patch v2] freezer: check OOM kill while being frozen Message-ID: <20140813092659.GA2775@dhcp22.suse.cz> References: <1407804835-24763-1-git-send-email-xiyou.wangcong@gmail.com> <20140812114430.GA7049@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 12-08-14 17:53:33, Cong Wang wrote: > On Tue, Aug 12, 2014 at 4:44 AM, Michal Hocko wrote: [...] > >> @@ -147,12 +156,6 @@ void __thaw_task(struct task_struct *p) > >> { > >> unsigned long flags; > >> > >> - /* > >> - * Clear freezing and kick @p if FROZEN. Clearing is guaranteed to > >> - * be visible to @p as waking up implies wmb. Waking up inside > >> - * freezer_lock also prevents wakeups from leaking outside > >> - * refrigerator. > >> - */ > > > > This is an unrelated change. > > > > It is, because as I explained, __thaw_task() doesn't do what this comment > says therefore needs this patch. Or you prefer to make it a separated patch? It is outdated since a3201227f803. I would do it in a separate patch but maybe just mention that the above commit has changed the implementation. -- Michal Hocko SUSE Labs