From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755324AbaHNPuJ (ORCPT ); Thu, 14 Aug 2014 11:50:09 -0400 Received: from service87.mimecast.com ([91.220.42.44]:48293 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755196AbaHNPuG convert rfc822-to-8bit (ORCPT ); Thu, 14 Aug 2014 11:50:06 -0400 Date: Thu, 14 Aug 2014 16:49:59 +0100 From: Liviu Dudau To: Wei Yang Cc: Bjorn Helgaas , Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , Arnd Bergmann , Russell King , Tanmay Inamdar , Grant Likely , Sinan Kaya , Jingoo Han , Kukjin Kim , Suravee Suthikulanit , linux-pci , linux-arch , LKML , Device Tree ML , LAKML Subject: Re: [PATCH v9 02/12] PCI: OF: Parse and map the IRQ when adding the PCI device. Message-ID: <20140814154959.GG25761@e106497-lin.cambridge.arm.com> References: <1407860725-25202-1-git-send-email-Liviu.Dudau@arm.com> <1407860725-25202-3-git-send-email-Liviu.Dudau@arm.com> <20140814145804.GA5586@richard> MIME-Version: 1.0 In-Reply-To: <20140814145804.GA5586@richard> User-Agent: Mutt/1.5.22 (2013-10-16) X-OriginalArrivalTime: 14 Aug 2014 15:50:00.0634 (UTC) FILETIME=[67EB01A0:01CFB7D7] X-MC-Unique: 114081416500302101 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 14, 2014 at 03:58:04PM +0100, Wei Yang wrote: > On Tue, Aug 12, 2014 at 05:25:15PM +0100, Liviu Dudau wrote: > >Enhance the default implementation of pcibios_add_device() to > >parse and map the IRQ of the device if a DT binding is available. > > > >Cc: Bjorn Helgaas > >Cc: Grant Likely > >Cc: Rob Herring > >Signed-off-by: Liviu Dudau > >--- > > drivers/pci/pci.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > >diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > >index 1c8592b..29d1775 100644 > >--- a/drivers/pci/pci.c > >+++ b/drivers/pci/pci.c > >@@ -17,6 +17,7 @@ > > #include > > #include > > #include > >+#include > > #include > > #include > > #include > >@@ -1453,6 +1454,8 @@ EXPORT_SYMBOL(pcim_pin_device); > > */ > > int __weak pcibios_add_device(struct pci_dev *dev) > > { > >+ dev->irq = of_irq_parse_and_map_pci(dev, 0, 0); > >+ > > return 0; > > } > > Liviu, > > For this, my suggestion is to add arch dependent function to setup the irq > line for pci devices. I can't find an obvious reason this won't work on other > archs, but maybe this will hurt some of them? Hi Wei, I'm not sure I understand your point. Architectures that support OF will obviously benefit from this common approach, and for the other ones the function is empty so it will not change existing behaviour. If you are suggesting that I should create a new API that each architecture could go and implement for setting up the IRQ line then I would agree that it would be nice to have that, but the question is how many architectures are outside OF that need this? If I understood you correctly, it is a nice idea but slightly outside the scope of my current patchset. Best regards, Liviu > > > > >-- > >2.0.4 > > > >-- > >To unsubscribe from this list: send the line "unsubscribe linux-pci" in > >the body of a message to majordomo@vger.kernel.org > >More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- > Richard Yang > Help you, Help me > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯