From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752351AbaHOIXQ (ORCPT ); Fri, 15 Aug 2014 04:23:16 -0400 Received: from cantor2.suse.de ([195.135.220.15]:44859 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751703AbaHOIXO (ORCPT ); Fri, 15 Aug 2014 04:23:14 -0400 Date: Fri, 15 Aug 2014 10:23:10 +0200 From: Michal Hocko To: Cong Wang Cc: linux-kernel@vger.kernel.org, David Rientjes , "Rafael J. Wysocki" , Tejun Heo , Andrew Morton Subject: Re: [Patch v3 2/2] freezer: remove obsolete comments in __thaw_task() Message-ID: <20140815082310.GA24624@dhcp22.suse.cz> References: <1408050926-9525-1-git-send-email-xiyou.wangcong@gmail.com> <1408050926-9525-2-git-send-email-xiyou.wangcong@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1408050926-9525-2-git-send-email-xiyou.wangcong@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 14-08-14 14:15:26, Cong Wang wrote: > __thaw_task() no longer clears frozen flag. since a3201227f803 (freezer: make freezing() test freeze conditions in effect instead of TIF_FREEZE). > Cc: David Rientjes > Cc: "Rafael J. Wysocki" > Cc: Tejun Heo > Cc: Andrew Morton > Cc: Michal Hocko > Signed-off-by: Cong Wang Reviewed-by: Michal Hocko > --- > kernel/freezer.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/kernel/freezer.c b/kernel/freezer.c > index 5b25351..33cbcb0 100644 > --- a/kernel/freezer.c > +++ b/kernel/freezer.c > @@ -156,12 +156,6 @@ void __thaw_task(struct task_struct *p) > { > unsigned long flags; > > - /* > - * Clear freezing and kick @p if FROZEN. Clearing is guaranteed to > - * be visible to @p as waking up implies wmb. Waking up inside > - * freezer_lock also prevents wakeups from leaking outside > - * refrigerator. > - */ > spin_lock_irqsave(&freezer_lock, flags); > if (frozen(p)) > wake_up_process(p); > -- > 1.8.3.1 > -- Michal Hocko SUSE Labs