From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Peter Griffin <peter.griffin@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, chris@printf.net,
ulf.hansson@linaro.org, linux-mmc@vger.kernel.org,
zhangfei.gao@marvell.com, prakity@marvell.com,
patches@linaro.org, lee.jones@linaro.org
Subject: Re: [PATCH] mmc: sdhci-pxav3: set_uhs_signaling is initialized twice differently
Date: Fri, 15 Aug 2014 10:47:08 +0100 [thread overview]
Message-ID: <20140815094707.GW30401@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1408093958-26058-1-git-send-email-peter.griffin@linaro.org>
On Fri, Aug 15, 2014 at 10:12:38AM +0100, Peter Griffin wrote:
> .set_uhs_signaling field is currently initialised twice once to the
> arch specific callback pxav3_set_uhs_signaling, and also to the generic
> sdhci_set_uhs_signaling callback.
>
> This means that uhs is currently broken for this platform currently, as pxav3
> has some special constriants which means it can't use the generic callback.
>
> This happened in
> commit 96d7b78cfc2f ("mmc: sdhci: convert sdhci_set_uhs_signaling() into a library function")
> commit a702c8abb2a9 ("mmc: host: split up sdhci-pxa, create sdhci-pxav3.c")'
This is exactly why named initialisers should always follow the
declaration order in the structure definition.
It also helps avoid git merge to properly resolve two additions of
the same member (possibly with a conflict) rather than just adding
both.
--
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2014-08-15 9:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-15 9:12 Peter Griffin
2014-08-15 9:47 ` Russell King - ARM Linux [this message]
2014-08-15 12:52 ` Peter Griffin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140815094707.GW30401@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=chris@printf.net \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=peter.griffin@linaro.org \
--cc=prakity@marvell.com \
--cc=ulf.hansson@linaro.org \
--cc=zhangfei.gao@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®