mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	David Rientjes <rientjes@google.com>,
	Michal Hocko <mhocko@suse.cz>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [Patch v3 1/2] freezer: check OOM kill while being frozen
Date: Sat, 16 Aug 2014 08:20:28 -0400	[thread overview]
Message-ID: <20140816122028.GC9305@htj.dyndns.org> (raw)
In-Reply-To: <1408050926-9525-1-git-send-email-xiyou.wangcong@gmail.com>

On Thu, Aug 14, 2014 at 02:15:25PM -0700, Cong Wang wrote:
> +static bool should_thaw_current(bool check_kthr_stop)
> +{
> +	if (!freezing(current) ||
> +	    (check_kthr_stop && kthread_should_stop()) ||
> +	    test_thread_flag(TIF_MEMDIE))
> +		return true;
> +	else
> +		return false;
> +}

I'm not sure this is safe w.r.t. hibernation.  Please cc Rafael on
freezer related changes.

Thanks.

-- 
tejun

  parent reply	other threads:[~2014-08-16 12:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-14 21:15 Cong Wang
2014-08-14 21:15 ` [Patch v3 2/2] freezer: remove obsolete comments in __thaw_task() Cong Wang
2014-08-15  8:23   ` Michal Hocko
2014-08-16 12:20 ` Tejun Heo [this message]
2014-08-16 18:58   ` [Patch v3 1/2] freezer: check OOM kill while being frozen Cong Wang
2014-09-02 22:52   ` Cong Wang
2014-09-03 15:42     ` Tejun Heo
2014-09-04  4:47       ` Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140816122028.GC9305@htj.dyndns.org \
    --to=tj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhocko@suse.cz \
    --cc=rientjes@google.com \
    --cc=rjw@rjwysocki.net \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®