mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Alban Crequy <alban.crequy@collabora.co.uk>
Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
	Li Zefan <lizefan@huawei.com>
Subject: Re: [PATCH] [RFC] cgroup: reject cgroup names with non-printing characters
Date: Sun, 17 Aug 2014 09:41:59 -0400	[thread overview]
Message-ID: <20140817134159.GE7679@mtj.dyndns.org> (raw)
In-Reply-To: <1405955516-22016-1-git-send-email-alban.crequy@collabora.co.uk>

Hello, Alban.

Sorry about the delay.

On Mon, Jul 21, 2014 at 04:11:56PM +0100, Alban Crequy wrote:
> @@ -4387,6 +4401,11 @@ static int cgroup_mkdir(struct kernfs_node *parent_kn, const char *name,
>  	struct kernfs_node *kn;
>  	int ssid, ret;
>  
> +	/* do not create cgroups with bad names */
> +	ret = cgroup_is_used_badchars(name);
> +	if (ret)
> +		return ret;

Let's just reject '\n'.  That should give us a way to parse the path
correctly and I don't want to put more-than-necessary interpretation
on the path string.

Thanks.

-- 
tejun

      reply	other threads:[~2014-08-17 13:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-21 15:11 Alban Crequy
2014-08-17 13:41 ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140817134159.GE7679@mtj.dyndns.org \
    --to=tj@kernel.org \
    --cc=alban.crequy@collabora.co.uk \
    --cc=cgroups@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®