From: Jason Cooper <jason@lakedaemon.net>
To: Lee Jones <lee.jones@linaro.org>,
Rob Herring <robherring2@gmail.com>,
Grant Likely <grant.likely@secretlab.ca>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@stlinux.com,
tglx@linutronix.de, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/6] irqchip: irq-st: Add documentation for STi based syscfg IRQs
Date: Mon, 18 Aug 2014 08:05:45 -0400 [thread overview]
Message-ID: <20140818120545.GQ12769@titan.lakedaemon.net> (raw)
In-Reply-To: <1406642744-22589-4-git-send-email-lee.jones@linaro.org>
Hey Lee,
Rob, Grant, question for you below:
On Tue, Jul 29, 2014 at 03:05:41PM +0100, Lee Jones wrote:
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> .../interrupt-controller/st,sti-irq-syscfg.txt | 35 ++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/st,sti-irq-syscfg.txt
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/st,sti-irq-syscfg.txt b/Documentation/devicetree/bindings/interrupt-controller/st,sti-irq-syscfg.txt
> new file mode 100644
> index 0000000..ced6014
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/st,sti-irq-syscfg.txt
> @@ -0,0 +1,35 @@
> +STMicroelectronics STi System Configuration Controlled IRQs
> +-----------------------------------------------------------
> +
> +On STi based systems; External, CTI (Core Sight), PMU (Performance Management),
> +and PL310 L2 Cache IRQs are controlled using System Configuration registers.
> +This driver is used to unmask them prior to use.
We don't usually refer to the driver in binding docs as they are
supposed to be OS-agnostic.
> +
> +Required properties:
> +- compatible : Should be set to one of:
> + "st,stih415-irq-syscfg"
> + "st,stih416-irq-syscfg"
> + "st,stih407-irq-syscfg"
> + "st,stid127-irq-syscfg"
> +- st,syscfg : Phandle to Cortex-A9 IRQ system config registers
> +- st,irq-device : Array of IRQs to enable - should be 2 in length
> +- st,fiq-device : Array of FIQs to enable - should be 2 in length
> +
> +Optional properties:
> +- st,invert-ext : External IRQs can be inverted at will. This property inverts
> + these IRQs using bitwise logic. A number of defines have been
> + provided for convenience:
> + ST_IRQ_SYSCFG_EXT_1_INV
> + ST_IRQ_SYSCFG_EXT_2_INV
> + ST_IRQ_SYSCFG_EXT_3_INV
> +Example:
Rob, Grant, should we be mingling implementation details (macros from
include files) with the binding documentation? It just _seems_ wrong
too me. But if we agree that the binding docs, the dts files, and their
includes are always kept together, I also don't see the harm...
> +
> +irq-syscfg {
> + compatible = "st,stih416-irq-syscfg";
> + st,syscfg = <&syscfg_cpu>;
> + st,irq-device = <ST_IRQ_SYSCFG_PMU_0>,
> + <ST_IRQ_SYSCFG_PMU_1>;
> + st,fiq-device = <ST_IRQ_SYSCFG_DISABLED>,
> + <ST_IRQ_SYSCFG_DISABLED>;
> + st,invert-ext = <(ST_IRQ_SYSCFG_EXT_1_INV | ST_IRQ_SYSCFG_EXT_3_INV)>;
> +};
thx,
Jason.
next prev parent reply other threads:[~2014-08-18 12:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 14:05 [PATCH 0/5] irqchip: New driver for ST's SysCfg controlled IRQs Lee Jones
2014-07-29 14:05 ` [PATCH 1/6] dt: bindings: Supply shared ST IRQ defines Lee Jones
2014-07-29 14:05 ` [PATCH 2/6] irqchip: Supply new driver for STi based devices Lee Jones
2014-08-18 12:32 ` Jason Cooper
2014-09-26 9:34 ` Lee Jones
2014-07-29 14:05 ` [PATCH 3/6] irqchip: irq-st: Add documentation for STi based syscfg IRQs Lee Jones
2014-08-18 12:05 ` Jason Cooper [this message]
2014-09-26 9:51 ` Lee Jones
2014-07-29 14:05 ` [PATCH 4/6] ARM: STi: STiH416: Enable Cortex-A9 PMU support Lee Jones
2014-07-29 14:05 ` [PATCH 5/6] ARM: STi: STiH416: Enable PMU IRQs Lee Jones
2014-07-29 14:05 ` [PATCH 6/6] ARM: STI: Ensure requested STi's SysCfg Controlled IRQs are enabled at boot Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140818120545.GQ12769@titan.lakedaemon.net \
--to=jason@lakedaemon.net \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@secretlab.ca \
--cc=kernel@stlinux.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robherring2@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®