From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751451AbaHRN5r (ORCPT ); Mon, 18 Aug 2014 09:57:47 -0400 Received: from mga11.intel.com ([192.55.52.93]:26167 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750709AbaHRN5q (ORCPT ); Mon, 18 Aug 2014 09:57:46 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,886,1400050800"; d="scan'208";a="586372706" Date: Mon, 18 Aug 2014 16:57:37 +0300 From: Heikki Krogerus To: Sebastian Andrzej Siewior Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tony@atomide.com, balbi@ti.com, Vinod Koul , Greg Kroah-Hartman Subject: Re: [PATCH 06/15] tty: serial: 8250_dma: handle error on TX submit Message-ID: <20140818135737.GB32400@xps8300> References: <1408124563-31541-1-git-send-email-bigeasy@linutronix.de> <1408124563-31541-7-git-send-email-bigeasy@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1408124563-31541-7-git-send-email-bigeasy@linutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 15, 2014 at 07:42:34PM +0200, Sebastian Andrzej Siewior wrote: > diff --git a/include/linux/serial_8250.h b/include/linux/serial_8250.h > index b161eee..02e82dc 100644 > --- a/include/linux/serial_8250.h > +++ b/include/linux/serial_8250.h > @@ -85,6 +85,7 @@ struct uart_8250_port { > unsigned char mcr_force; /* mask of forced bits */ > unsigned char cur_iotype; /* Running I/O type */ > unsigned char rpm_tx_active; > + unsigned char dma_tx_err; Why not make this member of uart_8250_dma instead? -- heikki