From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753246AbaHSPPU (ORCPT ); Tue, 19 Aug 2014 11:15:20 -0400 Received: from mga09.intel.com ([134.134.136.24]:60037 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751260AbaHSPPS (ORCPT ); Tue, 19 Aug 2014 11:15:18 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,894,1400050800"; d="scan'208";a="590249426" Date: Tue, 19 Aug 2014 18:14:28 +0300 From: Mika Westerberg To: Guenter Roeck Cc: Wim Van Sebroeck , linux-kernel@vger.kernel.org Subject: Re: [PATCH] watchdog: ts72xx_wdt: Kill superfluous variable in remove Message-ID: <20140819151428.GT1660@lahna.fi.intel.com> References: <1408449432-25274-1-git-send-email-mika.westerberg@linux.intel.com> <20140819145916.GC18536@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140819145916.GC18536@roeck-us.net> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 19, 2014 at 07:59:16AM -0700, Guenter Roeck wrote: > On Tue, Aug 19, 2014 at 02:57:12PM +0300, Mika Westerberg wrote: > > There is no need to store the return value of misc_deregister() in a > > variable. Instead we can just return the value directly. > > > > Signed-off-by: Mika Westerberg > > --- > > drivers/watchdog/ts72xx_wdt.c | 6 +----- > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > diff --git a/drivers/watchdog/ts72xx_wdt.c b/drivers/watchdog/ts72xx_wdt.c > > index afa9d6ef353a..dee9c6cbe6df 100644 > > --- a/drivers/watchdog/ts72xx_wdt.c > > +++ b/drivers/watchdog/ts72xx_wdt.c > > @@ -428,11 +428,7 @@ static int ts72xx_wdt_probe(struct platform_device *pdev) > > > > static int ts72xx_wdt_remove(struct platform_device *pdev) > > { > > - int error; > > - > > - error = misc_deregister(&ts72xx_wdt_miscdev); > > - > > - return error; > > + return misc_deregister(&ts72xx_wdt_miscdev); > > Is that worth it, and does it even reduce code size ? Well, it makes that particular function look better. > Converting the driver to use the watchdog infrastructure would make much more sense > (if someone can test the result). I agree that converting makes sense, but that is subject of a separate patch.