mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Don Zickus <dzickus@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>,
	eranian@google.com, LKML <linux-kernel@vger.kernel.org>,
	Joe Mario <jmario@redhat.com>
Subject: Re: [PATCH] perf, map:  Don't try to find DSOs in SYSV maps
Date: Wed, 20 Aug 2014 08:25:49 -0300	[thread overview]
Message-ID: <20140820112549.GB2892@kernel.org> (raw)
In-Reply-To: <1408501874-244377-1-git-send-email-dzickus@redhat.com>

Em Tue, Aug 19, 2014 at 10:31:14PM -0400, Don Zickus escreveu:
> We are seeing a lot of the following with regards to SYSV memory
> 
> Failed to open /SYSV0000279c, continuing without symbols
> 
> We don't believe this memory will have DSO info, so treat it like the heap and
> stack for now and skip it to prevent the warning.

Thanks, applied.
 
> Signed-off-by: Joe Mario <jmario@redhat.com>
> Signed-off-by: Don Zickus <dzickus@redhat.com>
> --
> I am open to suggetions for a different fix - dcz
> ---
>  tools/perf/util/map.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/tools/perf/util/map.c b/tools/perf/util/map.c
> index 25c571f..0294f40 100644
> --- a/tools/perf/util/map.c
> +++ b/tools/perf/util/map.c
> @@ -29,6 +29,7 @@ static inline int is_anon_memory(const char *filename)
>  static inline int is_no_dso_memory(const char *filename)
>  {
>  	return !strncmp(filename, "[stack", 6) ||
> +	       !strncmp(filename, "/SYSV",5)   ||
>  	       !strcmp(filename, "[heap]");
>  }
>  
> -- 
> 1.7.1

  reply	other threads:[~2014-08-20 11:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-20  2:31 Don Zickus
2014-08-20 11:25 ` Arnaldo Carvalho de Melo [this message]
2014-08-24 14:56 ` [tip:perf/core] perf symbols: " tip-bot for Don Zickus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140820112549.GB2892@kernel.org \
    --to=acme@kernel.org \
    --cc=dzickus@redhat.com \
    --cc=eranian@google.com \
    --cc=jmario@redhat.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome