From: Mark Brown <broonie@kernel.org>
To: Axel Lin <axel.lin@ingics.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Guodong Xu <guodong.xu@linaro.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: core: Fix build error due to const qualifier for ops
Date: Wed, 20 Aug 2014 10:17:41 -0500 [thread overview]
Message-ID: <20140820151741.GU24407@sirena.org.uk> (raw)
In-Reply-To: <CAFRkauAZGnd5JDkvYtZDbNPTt1JT==zyg1a96hbkY24h2kofng@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 637 bytes --]
On Wed, Aug 20, 2014 at 10:51:33AM +0800, Axel Lin wrote:
> As I mentioned in the commit log:
> Drop const qualifier for ops of struct regulator_desc.
> Allow regulator drivers to update ops before registering regulator.
> So I don't think it's necessary to add const for ops in struct
> regulator_desc.
> (I think the original point was the "regulator core" won't modify the ops).
> The fix is either drop the 'const' qualifier in hi6421-regulator driver or
> add back const qualifier for ops of struct regulator_desc in
> include/linux/regulator/driver.h.
> Which one do you prefer?
Adding back the const qualifier.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2014-08-20 15:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-18 2:34 Axel Lin
2014-08-18 13:06 ` Guodong Xu
2014-08-18 14:10 ` Mark Brown
2014-08-20 2:51 ` Axel Lin
2014-08-20 15:17 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140820151741.GU24407@sirena.org.uk \
--to=broonie@kernel.org \
--cc=axel.lin@ingics.com \
--cc=guodong.xu@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome