From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752292AbaHTP44 (ORCPT ); Wed, 20 Aug 2014 11:56:56 -0400 Received: from mail-qa0-f46.google.com ([209.85.216.46]:63645 "EHLO mail-qa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751812AbaHTP4y (ORCPT ); Wed, 20 Aug 2014 11:56:54 -0400 Date: Wed, 20 Aug 2014 16:56:46 +0100 From: Lee Jones To: Mika Westerberg Cc: linux-kernel@vger.kernel.org, Peter Tyser , Samuel Ortiz , Alan Cox Subject: Re: [PATCH] mfd: lpc_ich: Add PCI ID for Intel Braswell Message-ID: <20140820155646.GN4266@lee--X1> References: <1408462743-9462-1-git-send-email-mika.westerberg@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1408462743-9462-1-git-send-email-mika.westerberg@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 19 Aug 2014, Mika Westerberg wrote: > From: Alan Cox > > This is the same as used in Baytrail so add the new PCI ID to the driver's > list of supported IDs. > > Signed-off-by: Alan Cox > Signed-off-by: Mika Westerberg > --- > drivers/mfd/lpc_ich.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c > index 7d8482ff5868..597f5f495d49 100644 > --- a/drivers/mfd/lpc_ich.c > +++ b/drivers/mfd/lpc_ich.c > @@ -216,6 +216,7 @@ enum lpc_chipsets { > LPC_BAYTRAIL, /* Bay Trail SoC */ > LPC_COLETO, /* Coleto Creek */ > LPC_WPT_LP, /* Wildcat Point-LP */ > + LPC_BRASWELL, /* Braswell SoC */ > }; > > static struct lpc_ich_info lpc_chipset_info[] = { > @@ -519,6 +520,10 @@ static struct lpc_ich_info lpc_chipset_info[] = { > .name = "Wildcat Point_LP", > .iTCO_version = 2, > }, > + [LPC_BRASWELL] = { > + .name = "Braswell SoC", > + .iTCO_version = 3, > + }, > }; > > /* > @@ -745,6 +750,7 @@ static const struct pci_device_id lpc_ich_ids[] = { > { PCI_VDEVICE(INTEL, 0x9cc6), LPC_WPT_LP}, > { PCI_VDEVICE(INTEL, 0x9cc7), LPC_WPT_LP}, > { PCI_VDEVICE(INTEL, 0x9cc9), LPC_WPT_LP}, > + { PCI_VDEVICE(INTEL, 0x229C), LPC_BRASWELL}, Nit: All the other numbers are in lower case. Please fix and re-send. > { 0, }, /* End of list */ > }; > MODULE_DEVICE_TABLE(pci, lpc_ich_ids); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog