From: David Miller <davem@davemloft.net>
To: jonas.jensen@gmail.com
Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, f.fainelli@gmail.com,
eric.dumazet@gmail.com
Subject: Re: [PATCH v5 1/2] net: moxa: clear TX descriptor length bits
Date: Thu, 21 Aug 2014 21:39:29 -0700 (PDT) [thread overview]
Message-ID: <20140821.213929.2048600939729474726.davem@davemloft.net> (raw)
In-Reply-To: <1408544322-32023-1-git-send-email-jonas.jensen@gmail.com>
From: Jonas Jensen <jonas.jensen@gmail.com>
Date: Wed, 20 Aug 2014 16:18:42 +0200
> @@ -348,7 +348,8 @@ static int moxart_mac_start_xmit(struct sk_buff *skb, struct net_device *ndev)
>
> txdes1 = readl(desc + TX_REG_OFFSET_DESC1);
> txdes1 |= TX_DESC1_LTS | TX_DESC1_FTS;
> - txdes1 &= ~(TX_DESC1_FIFO_COMPLETE | TX_DESC1_INTR_COMPLETE);
> + txdes1 &= ~(TX_DESC1_FIFO_COMPLETE | TX_DESC1_INTR_COMPLETE |
> + TX_DESC1_BUF_SIZE_MASK);
> txdes1 |= (len & TX_DESC1_BUF_SIZE_MASK);
> writel(txdes1, desc + TX_REG_OFFSET_DESC1);
> writel(TX_DESC0_DMA_OWN, desc + TX_REG_OFFSET_DESC0);
Like others I wonder why the existing descriptor value is being read
at all.
It's inefficient and completely unnecessary, you can just compute a new
value from scratch, and that way all of these "uncleared field" issues
just automatically disappear.
next prev parent reply other threads:[~2014-08-22 4:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 14:49 [PATCH v4 " Jonas Jensen
2014-08-19 14:49 ` [PATCH v4 2/2] net: moxa: replace build_skb() with netdev_alloc_skb_ip_align() / memcpy() Jonas Jensen
2014-08-19 18:31 ` Eric Dumazet
2014-08-20 14:24 ` Jonas Jensen
2014-08-20 14:19 ` [PATCH v5 " Jonas Jensen
2014-08-25 14:22 ` [PATCH v6 2/4] " Jonas Jensen
2014-08-26 0:26 ` David Miller
2014-08-26 9:04 ` Arnd Bergmann
2014-08-26 9:10 ` David Laight
2014-08-26 10:55 ` Eric Dumazet
2014-08-21 21:43 ` [PATCH v4 2/2] " Michał Mirosław
2014-08-25 14:23 ` Jonas Jensen
2014-08-20 14:18 ` [PATCH v5 1/2] net: moxa: clear TX descriptor length bits Jonas Jensen
2014-08-20 17:10 ` Eric Dumazet
2014-08-25 14:23 ` Jonas Jensen
2014-08-22 4:39 ` David Miller [this message]
2014-08-25 14:22 ` [PATCH v6 1/4] net: moxa: clear DESC1 on ndo_start_xmit() Jonas Jensen
2014-08-26 0:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140821.213929.2048600939729474726.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=jonas.jensen@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®