From: Andrew Morton <akpm@linux-foundation.org>
To: Pranith Kumar <bobby.prani@gmail.com>
Cc: Doug Thompson <dougthompson@xmission.com>,
Borislav Petkov <bp@alien8.de>,
Mauro Carvalho Chehab <m.chehab@samsung.com>,
linux-edac@vger.kernel.org (open list:EDAC-CORE),
linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH] edac: Fix build error caused by wrong member access
Date: Thu, 21 Aug 2014 14:28:44 -0700 [thread overview]
Message-ID: <20140821142844.741564f85014633db067408f@linux-foundation.org> (raw)
In-Reply-To: <1408482646-22541-1-git-send-email-bobby.prani@gmail.com>
On Tue, 19 Aug 2014 17:10:46 -0400 Pranith Kumar <bobby.prani@gmail.com> wrote:
> Fix the following error
>
> drivers/edac/ppc4xx_edac.c:977:45: error: request for member 'dimm' in something
> not a structure or union
>
> by changing member access to pointer dereference
>
> --- a/drivers/edac/ppc4xx_edac.c
> +++ b/drivers/edac/ppc4xx_edac.c
> @@ -974,7 +974,7 @@ static int ppc4xx_edac_init_csrows(struct mem_ctl_info *mci, u32 mcopt1)
> * page size (PAGE_SIZE) or the memory width (2 or 4).
> */
> for (j = 0; j < csi->nr_channels; j++) {
> - struct dimm_info *dimm = csi->channels[j].dimm;
> + struct dimm_info *dimm = csi->channels[j]->dimm;
>
> dimm->nr_pages = nr_pages / csi->nr_channels;
> dimm->grain = 1;
This driver seems pretty unhealthy and I suspect it has been
broken for quite a while.
drivers/edac/ppc4xx_edac.c: In function 'mfsdram':
drivers/edac/ppc4xx_edac.c:249: error: implicit declaration of function '__mfdcri'
drivers/edac/ppc4xx_edac.c: In function 'mtsdram':
drivers/edac/ppc4xx_edac.c:266: error: implicit declaration of function '__mtdcri'
drivers/edac/ppc4xx_edac.c:269: warning: 'return' with a value, in function returning void
drivers/edac/ppc4xx_edac.c: In function 'ppc4xx_edac_init_csrows':
drivers/edac/ppc4xx_edac.c:924: warning: initialization from incompatible pointer type
drivers/edac/ppc4xx_edac.c:977: error: request for member 'dimm' in something not a structure or union
drivers/edac/ppc4xx_edac.c: In function 'ppc4xx_edac_map_dcrs':
drivers/edac/ppc4xx_edac.c:1209: warning: passing argument 1 of 'dcr_map_mmio' discards qualifiers from pointer target type
next prev parent reply other threads:[~2014-08-21 21:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 21:10 Pranith Kumar
2014-08-21 21:28 ` Andrew Morton [this message]
2014-08-21 23:46 ` Pranith Kumar
2014-09-15 12:21 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140821142844.741564f85014633db067408f@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bobby.prani@gmail.com \
--cc=bp@alien8.de \
--cc=dougthompson@xmission.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.chehab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®