From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753150AbaHURHI (ORCPT ); Thu, 21 Aug 2014 13:07:08 -0400 Received: from mail-qc0-f182.google.com ([209.85.216.182]:44464 "EHLO mail-qc0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752170AbaHURHG (ORCPT ); Thu, 21 Aug 2014 13:07:06 -0400 Date: Thu, 21 Aug 2014 12:07:01 -0500 From: Tejun Heo To: Andrea Righi Cc: Li Zefan , Steven Rostedt , Ingo Molnar , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Matt Heaton Subject: Re: [PATCH] cgroup: add tracepoints to track cgroup events Message-ID: <20140821170701.GA3940@mtj.dyndns.org> References: <1408592785-6700-1-git-send-email-andrea@betterlinux.com> <20140821141330.GA1766@mtj.dyndns.org> <20140821153541.GA7625@Dell> <20140821170002.GB7625@Dell> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140821170002.GB7625@Dell> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Anrea. On Thu, Aug 21, 2014 at 11:00:02AM -0600, Andrea Righi wrote: > hmm... am I missing something or we already support directory events? Ah, right, those mkdir/rmdir and writes automatically generate those events. > root@Dell:~# grep cgroups /proc/mounts > none /cgroups cgroup rw,relatime,cpuset,cpu,cpuacct,memory,devices,freezer,perf_event,hugetlb 0 0 > root@Dell:~# inotifywait -m -r -e modify -e move -e create -e delete /cgroups > Setting up watches. Beware: since -r was given, this may take a while! > Watches established. > /cgroups/ CREATE,ISDIR test > /cgroups/test/ MODIFY cgroup.procs > /cgroups/test/ MODIFY cgroup.procs > /cgroups/test/ MODIFY cgroup.populated > /cgroups/ MODIFY cgroup.procs > /cgroups/ MODIFY cgroup.procs > /cgroups/test/ MODIFY cgroup.populated > /cgroups/ DELETE,ISDIR test > > I still need to figure out a smart way to track which PIDs are > added/removed to/from cgroup.procs from userland (inotifywait + git? :)), > but all the other informations provided by my tracepoint patch seem to > be already available via [di]notify. Hmmm... yeah, determining exactly which pids got added / removed can be cumbersome from just MODIFY events. That said, what are you trying to do with such information? Thanks. -- tejun