From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751959AbaHVT2f (ORCPT ); Fri, 22 Aug 2014 15:28:35 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:53534 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751878AbaHVT2c (ORCPT ); Fri, 22 Aug 2014 15:28:32 -0400 Date: Fri, 22 Aug 2014 12:28:31 -0700 (PDT) Message-Id: <20140822.122831.451083152510385540.davem@davemloft.net> To: bernat.ada@gmail.com Cc: stephen@networkplumber.org, bridge@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, paulmck@linux.vnet.ibm.com Subject: Re: [PATCH] br_multicast: Replace rcu_assign_pointer() with RCU_INIT_POINTER() From: David Miller In-Reply-To: <20140822130609.GA19576@ada> References: <20140822130609.GA19576@ada> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Fri, 22 Aug 2014 12:28:31 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andreea-Cristina Bernat Date: Fri, 22 Aug 2014 16:06:09 +0300 > The use of "rcu_assign_pointer()" is NULLing out the pointer. > According to RCU_INIT_POINTER()'s block comment: > "1. This use of RCU_INIT_POINTER() is NULLing out the pointer" > it is better to use it instead of rcu_assign_pointer() because it has a > smaller overhead. ... > Signed-off-by: Andreea-Cristina Bernat Applied.