From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751980AbaHVT2r (ORCPT ); Fri, 22 Aug 2014 15:28:47 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:53539 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751149AbaHVT2q (ORCPT ); Fri, 22 Aug 2014 15:28:46 -0400 Date: Fri, 22 Aug 2014 12:28:45 -0700 (PDT) Message-Id: <20140822.122845.47909761068311924.davem@davemloft.net> To: himangi774@gmail.com Cc: linux-decnet-user@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, julia.lawall@lip6.fr Subject: Re: [PATCH] dn_dev: Use time_before From: David Miller In-Reply-To: <20140820174306.GA4180@himangi-Dell> References: <20140820174306.GA4180@himangi-Dell> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Fri, 22 Aug 2014 12:28:45 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Himangi Saraogi Date: Wed, 20 Aug 2014 23:13:07 +0530 > The functions time_before, time_before_eq, time_after, and time_after_eq > are more robust for comparing jiffies against other values. > > A simplified version of the Coccinelle semantic patch making this change > is as follows: > > @change@ > expression E1,E2; > @@ > > ( > - (jiffies - E1) < E2 > + time_before(jiffies, E1+E2) > ) > > Signed-off-by: Himangi Saraogi > Acked-by: Julia Lawall Applied.