From: Steven Rostedt <rostedt@goodmis.org>
To: Andreea-Cristina Bernat <bernat.ada@gmail.com>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org,
paulmck@linux.vnet.ibm.com
Subject: Re: [PATCH] kernel: trace_syscalls: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
Date: Fri, 22 Aug 2014 11:37:58 -0400 [thread overview]
Message-ID: <20140822113758.172eb474@gandalf.local.home> (raw)
In-Reply-To: <20140822142822.GA32391@ada>
On Fri, 22 Aug 2014 17:28:22 +0300
Andreea-Cristina Bernat <bernat.ada@gmail.com> wrote:
> The uses of "rcu_assign_pointer()" are NULLing out the pointers.
> According to RCU_INIT_POINTER()'s block comment:
> "1. This use of RCU_INIT_POINTER() is NULLing out the pointer"
> it is better to use it instead of rcu_assign_pointer() because it has a
> smaller overhead.
>
> The following Coccinelle semantic patch was used:
> @@
> @@
>
> - rcu_assign_pointer
> + RCU_INIT_POINTER
> (..., NULL)
I guess I can add this. It's a very slow path thus it isn't critical.
Although, I hate the name. Perhaps we should add another macro called
RCU_CLEAR_POINTER() or something that just nulls it. That way it
documents the use. To me, INIT means the pointer is being initialized,
where in reality it's just being cleared. I guess one could argue that
the pointer is being "re-initialized".
Thanks!
-- Steve
>
> Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
> ---
> kernel/trace/trace_syscalls.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscalls.c
> index 759d5e0..4dc8b79 100644
> --- a/kernel/trace/trace_syscalls.c
> +++ b/kernel/trace/trace_syscalls.c
> @@ -425,7 +425,7 @@ static void unreg_event_syscall_enter(struct ftrace_event_file *file,
> return;
> mutex_lock(&syscall_trace_lock);
> tr->sys_refcount_enter--;
> - rcu_assign_pointer(tr->enter_syscall_files[num], NULL);
> + RCU_INIT_POINTER(tr->enter_syscall_files[num], NULL);
> if (!tr->sys_refcount_enter)
> unregister_trace_sys_enter(ftrace_syscall_enter, tr);
> mutex_unlock(&syscall_trace_lock);
> @@ -463,7 +463,7 @@ static void unreg_event_syscall_exit(struct ftrace_event_file *file,
> return;
> mutex_lock(&syscall_trace_lock);
> tr->sys_refcount_exit--;
> - rcu_assign_pointer(tr->exit_syscall_files[num], NULL);
> + RCU_INIT_POINTER(tr->exit_syscall_files[num], NULL);
> if (!tr->sys_refcount_exit)
> unregister_trace_sys_exit(ftrace_syscall_exit, tr);
> mutex_unlock(&syscall_trace_lock);
next prev parent reply other threads:[~2014-08-22 15:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 14:28 Andreea-Cristina Bernat
2014-08-22 15:37 ` Steven Rostedt [this message]
2014-08-25 22:56 ` Paul E. McKenney
2014-08-25 23:05 ` Steven Rostedt
2014-08-26 0:57 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140822113758.172eb474@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=bernat.ada@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®