From: Jiri Olsa <jolsa@redhat.com>
To: Jiri Olsa <jolsa@kernel.org>
Cc: linux-kernel@vger.kernel.org, Andi Kleen <andi@firstfloor.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@kernel.org>,
"Jen-Cheng(Tommy) Huang" <tommy24@gatech.edu>,
Namhyung Kim <namhyung@kernel.org>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Stephane Eranian <eranian@google.com>
Subject: Re: [RFC 0/5] perf: Allow leader sampling on inherited events
Date: Fri, 22 Aug 2014 15:30:56 +0200 [thread overview]
Message-ID: <20140822133056.GA22315@krava.brq.redhat.com> (raw)
In-Reply-To: <1408712718-19656-1-git-send-email-jolsa@kernel.org>
On Fri, Aug 22, 2014 at 03:05:13PM +0200, Jiri Olsa wrote:
> hi,
> Jen-Cheng(Tommy) Huang reported the leader sampling not working
> on children processes:
> http://www.mail-archive.com/linux-perf-users@vger.kernel.org/msg01644.html
>
> The leader sampling (example below) lets the group leader event (cycles)
> do the sampling and reads the rest of the group (cache-misses) via
> PERF_FORMAT_GROUP format.
>
> Example:
> $ perf record -e '{cycles,cache-misses}:S' <workload>
> $ perf report --group
>
> The perf report --group allows to see all events group
> data in single view.
>
> The reason for leader sampling being switched off for inherited
> events, is that the kernel does no allow PERF_FORMAT_GROUP format
> on inherited events (which is used by leader sampling).
>
> I switched on the PERF_FORMAT_GROUP format for inherited events
> with few other fixies in patches:
> perf: Deny optimized switch for events read by PERF_SAMPLE_READ
> perf: Allow PERF_FORMAT_GROUP format on inherited events
>
> And I fixed perf tool code to be able to process data from
> children processes.
>
> Anyway, I might have missed some other reason why this was
> never switched on in kernel, so sending this as RFC.
Also reachable in here:
git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
perf/core_format_group
jirka
next prev parent reply other threads:[~2014-08-22 13:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 13:05 Jiri Olsa
2014-08-22 13:05 ` [PATCH 1/5] perf: Deny optimized switch for events read by PERF_SAMPLE_READ Jiri Olsa
2014-08-22 13:05 ` [PATCH 2/5] perf: Allow PERF_FORMAT_GROUP format on inherited events Jiri Olsa
2014-08-22 13:05 ` [PATCH 3/5] perf tools: Add support to traverse xyarrays Jiri Olsa
2014-08-22 13:05 ` [PATCH 4/5] perf tools: Add hash of periods for struct perf_sample_id Jiri Olsa
2014-08-22 13:05 ` [PATCH 5/5] perf tools: Allow PERF_FORMAT_GROUP for inherited events Jiri Olsa
2014-08-22 13:30 ` Jiri Olsa [this message]
[not found] ` <CABooUW0qEpo2YhXfxHsf48mw1acuZ63bq=Fot3kH1eHOfryU-A@mail.gmail.com>
2014-08-23 20:07 ` [RFC 0/5] perf: Allow leader sampling on " Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140822133056.GA22315@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=tommy24@gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®