From: Steven Rostedt <rostedt@goodmis.org>
To: "Javi Merino" <javi.merino@arm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] trace-cmd: link trace-record in ctracecmd.so
Date: Fri, 22 Aug 2014 17:05:35 -0400 [thread overview]
Message-ID: <20140822170535.52f12438@gandalf.local.home> (raw)
In-Reply-To: <1408116698-23033-1-git-send-email-javi.merino@arm.com>
On Fri, 15 Aug 2014 16:31:38 +0100
"Javi Merino" <javi.merino@arm.com> wrote:
> Commit b1e9220819eb (trace-cmd: Report stats for all instances) moved
> tracecmd_stat_cpu() from trace-recorder.c to trace-record.c. This
> makes import ctracecmd fail in tracecmd.py:
>
> $ python tracecmd.py
> Traceback (most recent call last):
> File "tracecmd.py", line 22, in <module>
> from ctracecmd import *
> ImportError: ctracecmd.so: undefined symbol: tracecmd_stat_cpu
>
> Link trace-record in ctracecmd.so to add back the required symbol.
>
I just applied this. May push this out next week. I have other changes
I'm adding and need to get them finished before I push it out. It may
not go out until September though.
-- Steve
> Signed-off-by: Javi Merino <javi.merino@arm.com>
> ---
> Makefile | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index cbe0eb9..308d7f8 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -317,8 +317,9 @@ KERNEL_SHARK_OBJS = $(TRACE_VIEW_OBJS) $(TRACE_GRAPH_OBJS) $(TRACE_GUI_OBJS) \
>
> PEVENT_LIB_OBJS = event-parse.o trace-seq.o parse-filter.o parse-utils.o
> TCMD_LIB_OBJS = $(PEVENT_LIB_OBJS) trace-util.o trace-input.o trace-ftrace.o \
> - trace-output.o trace-recorder.o trace-restore.o trace-usage.o \
> - trace-blk-hack.o kbuffer-parse.o event-plugin.o
> + trace-output.o trace-record.o trace-recorder.o \
> + trace-restore.o trace-usage.o trace-blk-hack.o \
> + kbuffer-parse.o event-plugin.o
>
> PLUGIN_OBJS =
> PLUGIN_OBJS += plugin_jbd2.o
prev parent reply other threads:[~2014-08-22 21:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-15 15:31 Javi Merino
2014-08-22 21:05 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140822170535.52f12438@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=javi.merino@arm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®