From: Andi Kleen <ak@linux.intel.com>
To: kan.liang@intel.com
Cc: acme@kernel.org, jolsa@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] perf tools: parse the pmu event prefix and surfix
Date: Fri, 22 Aug 2014 13:19:04 -0700 [thread overview]
Message-ID: <20140822201904.GC5803@tassilo.jf.intel.com> (raw)
In-Reply-To: <1408736549-4630-2-git-send-email-kan.liang@intel.com>
> +/* The contents of the pmu_events should be in ascending sorted by symbol*/
> +static struct pmu_event_symbol pmu_events[] = {
> + { "abort", false},
> + { "capacity", false},
> + { "commit", false},
> + { "conflict", false},
> + { "el", true},
> + { "start", false},
> + { "tx", true},
This list should be read from sysfs, not hard coded.
-Andi
next prev parent reply other threads:[~2014-08-22 20:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 19:42 [PATCH 1/3] Revert "perf tools: Default to cpu// for events v5" kan.liang
2014-08-22 19:42 ` [PATCH 2/3] perf tools: parse the pmu event prefix and surfix kan.liang
2014-08-22 20:19 ` Andi Kleen [this message]
2014-08-22 19:42 ` [PATCH 3/3] perf tools: Add support to new style format of kernel PMU event kan.liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140822201904.GC5803@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@kernel.org \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®