From: Borislav Petkov <bp@alien8.de>
To: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
Cc: dougthompson@xmission.com, m.chehab@samsung.com,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] edac, amd64_edac: Modify usage of amd64_read_dct_pci_cfg()
Date: Mon, 25 Aug 2014 09:49:11 +0200 [thread overview]
Message-ID: <20140825074911.GA14365@nazgul.tnic> (raw)
In-Reply-To: <20140825054339.GA13911@nazgul.tnic>
On Mon, Aug 25, 2014 at 07:43:39AM +0200, Borislav Petkov wrote:
> This is almost unreadable now with all the family checks everywhere.
> You need to hide all that per-family logic
And while you're at it, we're caching all required family info in the
pvt, see per_family_init(), no need for using boot_cpu_data.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2014-08-25 7:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 22:19 Aravind Gopalakrishnan
2014-08-25 5:43 ` Borislav Petkov
2014-08-25 7:49 ` Borislav Petkov [this message]
2014-08-26 17:35 ` Aravind Gopalakrishnan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140825074911.GA14365@nazgul.tnic \
--to=bp@alien8.de \
--cc=aravind.gopalakrishnan@amd.com \
--cc=dougthompson@xmission.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.chehab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®