From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756165AbaHYQ15 (ORCPT ); Mon, 25 Aug 2014 12:27:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63886 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751240AbaHYQ1n (ORCPT ); Mon, 25 Aug 2014 12:27:43 -0400 Date: Mon, 25 Aug 2014 17:35:19 +0100 From: Alexander Gordeev To: Dan Williams , Vinod Koul Cc: "linux-kernel@vger.kernel.org" , Vinod Koul , "dmaengine@vger.kernel.org" , linux-pci@vger.kernel.org Subject: Re: [PATCH v2] ioat: Use pci_enable_msix_exact() instead of pci_enable_msix() Message-ID: <20140825163518.GB5853@agordeev.usersys.redhat.com> References: <2ba22558b5db90740d5833c35570c3e7cc1e359e.1394128952.git.agordeev@redhat.com> <20140306214356.GA16376@dhcp-26-207.brq.redhat.com> <20140307074932.GC2670@dhcp-26-207.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140307074932.GC2670@dhcp-26-207.brq.redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 07, 2014 at 08:49:32AM +0100, Alexander Gordeev wrote: > As result of deprecation of MSI-X/MSI enablement functions > pci_enable_msix() and pci_enable_msi_block() all drivers > using these two interfaces need to be updated to use the > new pci_enable_msi_range() or pci_enable_msi_exact() > and pci_enable_msix_range() or pci_enable_msix_exact() > interfaces. Dan, Vinod, This patch hangs in -next for quite some time. Would you release it, please? Thanks! > Function pci_enable_msix() returns a tri-state value while > pci_enable_msi_exact() is a canonical zero/-errno variant. > The former is being phased out in favor of the latter. > In case of 'ioat' there (should be) no difference. > > Signed-off-by: Alexander Gordeev > Cc: Dan Williams > Cc: Vinod Koul > Cc: dmaengine@vger.kernel.org > Cc: linux-pci@vger.kernel.org > Acked-by: Dan Williams > --- > drivers/dma/ioat/dma.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/dma/ioat/dma.c b/drivers/dma/ioat/dma.c > index 4e3549a..b76c148 100644 > --- a/drivers/dma/ioat/dma.c > +++ b/drivers/dma/ioat/dma.c > @@ -947,7 +947,7 @@ msix: > for (i = 0; i < msixcnt; i++) > device->msix_entries[i].entry = i; > > - err = pci_enable_msix(pdev, device->msix_entries, msixcnt); > + err = pci_enable_msix_exact(pdev, device->msix_entries, msixcnt); > if (err) > goto msi; > > -- > 1.7.7.6 > > -- > Regards, > Alexander Gordeev > agordeev@redhat.com -- Regards, Alexander Gordeev agordeev@redhat.com