From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758202AbaHZNe3 (ORCPT ); Tue, 26 Aug 2014 09:34:29 -0400 Received: from mail-pd0-f173.google.com ([209.85.192.173]:36780 "EHLO mail-pd0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755082AbaHZNe2 (ORCPT ); Tue, 26 Aug 2014 09:34:28 -0400 Date: Tue, 26 Aug 2014 19:04:20 +0530 From: Sudip Mukherjee To: Takashi Iwai Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sound: pci: ctxfi: fix broken user-visible string Message-ID: <20140826133420.GB21572@sudip-PC> References: <1409055734-2777-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 26, 2014 at 02:32:04PM +0200, Takashi Iwai wrote: > At Tue, 26 Aug 2014 17:52:14 +0530, > Sudip Mukherjee wrote: > > > > fixed broken user visible strings > > This text just repeats what the summary line says. Instead, you > should write *why* the patch is needed. Ditto for the previous > patch. > Hi, Resent both the patches , and also modified the changelog . Can you please review them again ... thanks sudip > > > Takashi